Fixed some warnings on MinGW target when compiling Socket.cpp.#1152
Fixed some warnings on MinGW target when compiling Socket.cpp.#1152MAJigsaw77 wants to merge 11 commits intoHaxeFoundation:masterfrom
MinGW target when compiling Socket.cpp.#1152Conversation
|
By looking at this issue #574 maybe something might break without |
|
@hughsando Can i get a review on this pr? |
|
Also should be investigated whether it is still necessary to set |
|
The unnecessary Here is a similar example from microsoft documentation of using
Mingw-w64 now defines So these changes seem to be correct. |
tobil4sk
left a comment
There was a problem hiding this comment.
As explained a both, these solutions to these warnings make sense and would be useful for cleaning up the compilation output with mingw.
This PR fixes the following build warnings:
Redefinition of
_WIN32_WINNT: The macro_WIN32_WINNTwas being redefined inSocket.cpp. A conditional check has been added to prevent this.Ignored
dllimportattribute: Warnings related to thedllimportattribute forinet_pton_funcandinet_ntop_funcwere addressed by removing the unnecessaryWINSOCK_API_LINKAGE.