Add eBay comparable-based physical asset valuations - #277
Merged
Merged
Conversation
Sumedh-Joshi
force-pushed
the
feat/65-ebay-comparable-valuations
branch
from
September 20, 2026 11:11
2b99e56 to
a30ce87
Compare
Monster0506
marked this pull request as draft
September 20, 2026 11:48
Sumedh-Joshi
force-pushed
the
feat/65-ebay-comparable-valuations
branch
from
September 20, 2026 11:54
a30ce87 to
4691ba6
Compare
Sumedh-Joshi
changed the base branch from
fix/occupation-salary-scale-validation
to
main
September 20, 2026 11:55
Sumedh-Joshi
force-pushed
the
feat/65-ebay-comparable-valuations
branch
from
September 20, 2026 12:16
4691ba6 to
a11593a
Compare
Monster0506
marked this pull request as ready for review
September 20, 2026 12:21
Sumedh-Joshi
force-pushed
the
feat/65-ebay-comparable-valuations
branch
from
September 20, 2026 12:29
a11593a to
43a58fb
Compare
Monster0506
force-pushed
the
feat/65-ebay-comparable-valuations
branch
from
September 20, 2026 13:13
43a58fb to
670ab29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements external comparable retrieval and explicit no-comps behavior for physical asset valuations, via eBay's Browse API.
AiEstimatedValuationService) when eBay itself fails — missing credentials, network error, rate limit — instead of surfacing "Failed to retrieve comparable market listings." to the user. A genuine zero-results response (the call succeeded, no comps exist) is left as-is; that's not a failure.Ebay:ClientId/Ebay:ClientSecret) and tests for OAuth flow, token reuse, request construction, response mapping (including condition/currency filtering), empty results, error handling without leaking the client secret, disk-cache reuse, and valuation/fallback behavior.Live-verified against eBay's real sandbox (not just mocks): confirmed the OAuth flow, that eBay's own
conditions:{...}filter does not reliably exclude "New" listings (hence the client-sideconditionIdre-check), and that sandbox inventory is sparse for real product names — which is exactly why the fallback matters. Rebuilt the container with real sandbox credentials and clicked Revalue on a live item: real token fetch, real Browse API search, result cached toApp_Data/ebay-search-cache/*.json.Note: this branch previously regressed to a SerpApi Google-Search scrape (see commit history) after the original eBay integration shipped. That code is fully removed here; eBay is the only market-data provider again.
Closes #65
Closes #66
Closes #67