fix: correct path handling in SlnParser to ensure proper file resolution#72
Merged
fix: correct path handling in SlnParser to ensure proper file resolution#72
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SlnParser to normalize the input solution path to an absolute path before parsing, improving reliability when callers provide relative paths.
Changes:
- Resolve
pathviaIFileSystem.GetFullPathbefore callingSolutionFile.Parse. - Parse the solution using the normalized full path to ensure consistent project path resolution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor but important update to the way solution files are handled in the
SlnParser. The method now ensures that the solution file path is always converted to a full path before parsing, which can help avoid issues with relative paths.pathto a full path usingfileSystem.GetFullPathbefore passing it toSolutionFile.Parsein theGetProjectPathsmethod ofSlnParser.cs.