Skip to content

fix: correct path handling in SlnParser to ensure proper file resolution#72

Merged
HandyS11 merged 1 commit intodevelopfrom
fix/sln-file-parsing
Apr 7, 2026
Merged

fix: correct path handling in SlnParser to ensure proper file resolution#72
HandyS11 merged 1 commit intodevelopfrom
fix/sln-file-parsing

Conversation

@HandyS11
Copy link
Copy Markdown
Owner

@HandyS11 HandyS11 commented Apr 7, 2026

This pull request makes a minor but important update to the way solution files are handled in the SlnParser. The method now ensures that the solution file path is always converted to a full path before parsing, which can help avoid issues with relative paths.

  • Always resolves the provided path to a full path using fileSystem.GetFullPath before passing it to SolutionFile.Parse in the GetProjectPaths method of SlnParser.cs.

Copilot AI review requested due to automatic review settings April 7, 2026 13:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates SlnParser to normalize the input solution path to an absolute path before parsing, improving reliability when callers provide relative paths.

Changes:

  • Resolve path via IFileSystem.GetFullPath before calling SolutionFile.Parse.
  • Parse the solution using the normalized full path to ensure consistent project path resolution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HandyS11 HandyS11 merged commit c45e19c into develop Apr 7, 2026
7 of 8 checks passed
@HandyS11 HandyS11 deleted the fix/sln-file-parsing branch April 7, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants