Mustafa Homsi

[homsi6313-art]

No description provided.

[github-actions]

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

[remarcmij]

Hi @homsi6313-art, thanks for submitting your assignment. I have some minor comments but will approve your PR now,

[remarcmij]

Correct, but it would be easier to check if you included the code to run the tests.

Suggested change

	}
	}
	console.log(isBookApplicable('javascript'));
	// Output: true
	console.log(isBookApplicable('javascript '));
	// Output: true
	console.log(isBookApplicable('python'));
	// Output: false
	console.log(isBookApplicable('JavaScript'));
	// Output: true
	console.log(isBookApplicable('JAVASCRIPT'));
	// Output: true

[remarcmij]

This regular expression matches one or more whitespace characters (spaces, tabs). If this is how you understand it too, then this is an excellent choice. However, I would have accepted a space constant as a separator too here.

Suggested change

	const parts = trimmed.split(/\s+/);
	const parts = trimmed.split(' ');

[remarcmij]

You are assuming here that if it is not MDY, it must be DMY. That happens to be the case in the example console.logs. Maybe you could return an error message when it is not DMY so that it prints with the console.log?

[remarcmij]

It is a best practice to separate function definitions with a blank line, for readability purposes.

[remarcmij]

Why are the function definitions from printWeatherReport() and calculateWindChill() indented like this?

[remarcmij]

Your code could be made DRYer still:

Suggested change

	printWeatherReport("Amsterdam", 22);
	// Wind chill calculation for City 1
	let windSpeed1 = 15;
	let windChill1 = 13.12 + 0.6215 * tempCelsius1 - 11.37 * Math.pow(windSpeed1, 0.16) + 0.3965 * tempCelsius1 * Math.pow(windSpeed1, 0.16);
	console.log("Wind chill in " + cityName1 + ": " + windChill1.toFixed(2) + "°C");
	printWeatherReport("berlin", 15);
	// Wind chill calculation for City 2
	let windSpeed2 = 20;
	let windChill2 = 13.12 + 0.6215 * tempCelsius2 - 11.37 * Math.pow(windSpeed2, 0.16) + 0.3965 * tempCelsius2 * Math.pow(windSpeed2, 0.16);
	console.log("Wind chill in " + cityName2 + ": " + windChill2.toFixed(2) + "°C");
	printWeatherReport("Copenhagen", 5);
	// Wind chill calculation for City 3
	let windSpeed3 = 25;
	let windChill3 = 13.12 + 0.6215 * tempCelsius3 - 11.37 * Math.pow(windSpeed3, 0.16) + 0.3965 * tempCelsius3 * Math.pow(windSpeed3, 0.16);
	console.log("Wind chill in " + cityName3 + ": " + windChill3.toFixed(2) + "°C");
	\ No newline at end of file
	printWindChill("Amsterdam", 22, 15);
	printWindChill("Berlin", 15, 20);
	printWindChill("Copenhagen", 5, 25);
	function printCityReport(city, tempCelsius, windSpeed) {
	printWeatherReport(city, tempCelsius);
	printWindChill(city, tempCelsius, windSpeed);
	}
	printCityReport('Amsterdam', 22, 15);
	printCityReport('Berlin', 15, 20);
	printCityReport('Copenhagen', 5, 25);