Alaa Nasher - Week 1 (Add the answer code to the assignment)#6
Open
Alaa2019-ml wants to merge 3 commits intoHackYourAssignment:mainfrom
Open
Alaa Nasher - Week 1 (Add the answer code to the assignment)#6Alaa2019-ml wants to merge 3 commits intoHackYourAssignment:mainfrom
Alaa2019-ml wants to merge 3 commits intoHackYourAssignment:mainfrom
Conversation
dardecena
requested changes
Sep 3, 2025
dardecena
left a comment
dardecena
left a comment
There was a problem hiding this comment.
Nice work overall.
Ex 4 and 5 need some work.
Comment on lines
+1
to
+15
| export function giveCompliment(name) { | ||
| const compliments = [ | ||
| 'kind', | ||
| 'smart', | ||
| 'beautiful', | ||
| 'strong', | ||
| 'brave', | ||
| 'talented', | ||
| 'generous', | ||
| 'helpful', | ||
| 'creative', | ||
| 'friendly', | ||
| ]; | ||
|
|
||
| return `You are ${compliments[Math.floor(Math.random() * compliments.length)]}, ${name}!`; |
There was a problem hiding this comment.
Great job using the string template literal method.
| function main() { | ||
| // TODO substitute your own name for "HackYourFuture" | ||
| const myName = 'HackYourFuture'; | ||
| const myName = 'Alaa'; |
Comment on lines
+1
to
+2
| export function calculateDogAge(age) { | ||
| return `Your doggie is ${age * 7} years old in dog years!`; |
Comment on lines
1
to
2
| function selectRandomly(arr) { | ||
| return arr[Math.floor(Math.random() * arr.length)]; |
There was a problem hiding this comment.
Good job. One point of improvement is to use a more descriptive name for the function parameter (eg. 'choices).
Comment on lines
+5
to
+11
| export function tellFortune(childrenArr, partnersArr, locationsArr, jobsArr) { | ||
| const numKids = selectRandomly(childrenArr); | ||
| const partnerName = selectRandomly(partnersArr); | ||
| const location = selectRandomly(locationsArr); | ||
| const jobTitle = selectRandomly(jobsArr); | ||
|
|
||
| return `You will be a ${jobTitle} in ${location}, married to ${partnerName} with ${numKids} kids.`; |
There was a problem hiding this comment.
Great! The function parameters and constants are both descriptive making the function easy to read and understand.
Comment on lines
+2
to
+6
| chips: 1.75, | ||
| juice: 2.4, | ||
| frenchfries: 4.99, | ||
| cake: 8.99, | ||
| choclate: 2.99, |
Comment on lines
9
to
14
| function calculateTotalPrice(obj) { | ||
| let sum = 0; | ||
| for (const [_, value] of Object.entries(obj)) { | ||
| sum += value; | ||
| } | ||
| return Number(sum.toFixed(2)); |
There was a problem hiding this comment.
Great job.
Challenge: What's another method you can use to add up the items in the object?
| function test1() { | ||
| console.log('\nTest 1: calculateTotalPrice should take one parameter'); | ||
| // TODO replace this comment with your code | ||
| console.assert(calculateTotalPrice.length === 1); |
Comment on lines
+24
to
+26
| const expected = 21.12; | ||
| const actual = calculateTotalPrice(cartForParty); | ||
| console.assert(actual === expected); |
Comment on lines
18
to
24
| function filterPrivateData(employeesRecord) { | ||
| const nonPrivateData = []; | ||
| for (let { name, occupation, email } of employeesRecord) { | ||
| nonPrivateData.push({ name, occupation, email }); | ||
| } | ||
| return nonPrivateData; | ||
| } |
There was a problem hiding this comment.
Good work!
Challenge: What's another method you can use to return a list of employees with the required key-values?
dardecena
approved these changes
Sep 11, 2025
Comment on lines
+3
to
+9
| function addToShoppingCart(item) { | ||
| shoppingCart.push(item); | ||
| if (shoppingCart.length > 3) { | ||
| shoppingCart.shift(); | ||
| } | ||
| const shoppingCartItems = shoppingCart.join(', '); | ||
| return `You bought ${shoppingCartItems}!`; |
Comment on lines
+2
to
+5
| shoppingCart.push(item); | ||
| if (shoppingCart.length > 3) { | ||
| shoppingCart.shift(); | ||
| } |
Comment on lines
+1
to
+2
| function selectRandomly(choices) { | ||
| return choices[Math.floor(Math.random() * choices.length)]; |
Comment on lines
+18
to
+26
| function filterPrivateData(employeesRecord) { | ||
| // const nonPrivateData = []; | ||
| // for (let { name, occupation, email } of employeesRecord) { | ||
| // nonPrivateData.push({ name, occupation, email }); | ||
| // } | ||
| const nonPrivateData = employeesRecord.map(({ name, occupation, email }) => { | ||
| return { name, occupation, email }; | ||
| }); | ||
| return nonPrivateData; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors fixed weeek 2 assignment