Integrate World Bank MCP server for economic context in news generation by Copilot · Pull Request #653 · Hack23/riksdagsmonitor

Copilot · 2026-02-28T04:33:24Z

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Add world-bank MCP server to .github/copilot-mcp.json - Create scripts/world-bank-client.ts (TypeScript REST client for World Bank API) - Create scripts/world-bank-context.ts (economic context provider with Swedish indicators) - Integrate economic context detection into article-quality-enhancer.ts - Update news-evening-analysis.md workflow with World Bank data instructions - Update news-article-generator.md workflow with World Bank reference - Add tests/world-bank-client.test.ts (30 tests) - Add tests/world-bank-context.test.ts (35 tests) - All 2102 tests pass Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-02-28T04:45:15Z

🏷️ Automatic Labeling Summary

This PR has been automatically labeled based on the files changed and PR metadata.

Applied Labels: documentation,workflow,riksdag-data,ci-cd,testing,refactor,size-xl,news,agentic-workflow

Label Categories

🗳️ Content: news, dashboard, visualization, intelligence
💻 Technology: html-css, javascript, workflow, security
📊 Data: cia-data, riksdag-data, data-pipeline, schema
🌍 I18n: i18n, translation, rtl
🔒 ISMS: isms, iso-27001, nist-csf, cis-controls
🏗️ Infrastructure: ci-cd, deployment, performance, monitoring
🔄 Quality: testing, accessibility, documentation, refactor
🤖 AI: agent, skill, agentic-workflow

For more information, see .github/labeler.yml.

github-actions · 2026-02-28T04:46:21Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

…egex comment Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

github-actions · 2026-02-28T04:52:32Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Integrates World Bank economic indicator support into the news-generation toolchain to optionally enrich articles with macroeconomic context and to surface a non-blocking quality recommendation for including that context.

Changes:

Added a World Bank REST client and an economic-context mapping/provider (indicators → policy areas/committees + localized headings).
Extended article quality scoring inputs with an optional hasEconomicContext metric and a non-blocking “recommend economic context” warning.
Updated agentic workflow docs and added Vitest coverage for the new client/context modules.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`scripts/world-bank-client.ts`	New World Bank API client with retry/timeout, indicator/country constants, and helper methods.
`scripts/world-bank-context.ts`	New indicator→policy/committee mapping, localized section headings, and economic-context detection helpers.
`scripts/article-quality-enhancer.ts`	Adds `hasEconomicContext` metric collection and a non-blocking recommendation warning.
`scripts/types/validation.ts`	Extends `QualityThresholds`/`QualityMetrics` with optional economic-context fields.
`tests/world-bank-client.test.ts`	Unit tests for client behavior (fetching, retry, error handling, compareCountries, constants).
`tests/world-bank-context.test.ts`	Unit tests for mappings, headings, indicator lookup, and context detection.
`.github/workflows/news-evening-analysis.md`	Documents optional World Bank MCP usage and indicator references for evening analysis.
`.github/workflows/news-article-generator.md`	Documents optional World Bank MCP usage and indicator references for article generation.
`.github/copilot-mcp.json`	Adds `world-bank` MCP server configuration via `@smithery/cli`.

Copilot · 2026-02-28T04:55:44Z

scripts/world-bank-client.ts

+    return (data[1] as RawIndicatorValue[])
+      .filter((item): item is RawIndicatorValue & { value: number } => item.value !== null && item.value !== undefined)
+      .map((item) => ({
+        countryId: item.country?.id ?? countryCode,
+        countryName: item.country?.value ?? countryCode,


getIndicator()’s JSDoc says results are sorted by date descending, but the implementation currently returns the API order without sorting. Since getLatestIndicator() and compareCountries() assume index 0 is the most recent, please sort the mapped results by numeric year (descending) (and optionally push empty/invalid dates to the end) before returning.

Fixed in a75983e. getIndicator() now sorts mapped results by numeric year descending, with invalid/empty dates pushed to the end. Added a dedicated test should sort results by date descending that verifies out-of-order API responses are correctly reordered.

Copilot · 2026-02-28T04:55:45Z

scripts/world-bank-client.ts

+  readonly indicatorId: string;
+  readonly indicatorName: string;
+  readonly date: string;
+  readonly value: number | null;


WorldBankDataPoint.value is typed as number | null, but getIndicator() filters out all null/undefined values, so callers will never see a data point with value: null. To avoid confusion for API consumers, either (a) change the type to number for returned data points (and keep filtering), or (b) stop filtering and let value be null when the API reports missing data (and update getLatestIndicator() accordingly).

Suggested change

readonly value: number | null;

readonly value: number;

Fixed in a75983e. Changed value type from number | null to number since the filter already excludes all null/undefined entries before returning.

Copilot · 2026-02-28T04:55:45Z

scripts/world-bank-context.ts

+  const lowerQuery = query.toLowerCase();
+  return ECONOMIC_INDICATORS.filter(
+    (indicator) =>
+      indicator.policyAreas.some((area) => area.toLowerCase().includes(lowerQuery)) ||
+      indicator.committees.some((c) => c.toLowerCase() === lowerQuery),


findRelevantIndicators() lowercases the query but doesn’t trim or guard against an empty/whitespace query. Because "" is contained in every string, an empty query will match every indicator via includes(''). Consider using const q = query.trim().toLowerCase(); and returning [] early when q.length === 0.

Suggested change

const lowerQuery = query.toLowerCase();

return ECONOMIC_INDICATORS.filter(

(indicator) =>

indicator.policyAreas.some((area) => area.toLowerCase().includes(lowerQuery)) ||

indicator.committees.some((c) => c.toLowerCase() === lowerQuery),

const q = query.trim().toLowerCase();

if (q.length === 0) {

return [];

}

return ECONOMIC_INDICATORS.filter(

(indicator) =>

indicator.policyAreas.some((area) => area.toLowerCase().includes(q)) ||

indicator.committees.some((c) => c.toLowerCase() === q),

Fixed in a75983e. findRelevantIndicators() now trims and checks for empty query, returning [] early when q.length === 0. Added tests for both empty string and whitespace-only inputs.

Copilot · 2026-02-28T04:55:45Z

scripts/world-bank-context.ts

+    /\bförsvarsutgifter\b/i, // Swedish: defense expenditure
+    /\bforskningsutgifter\b/i, // Swedish: R&D expenditure


In hasEconomicContext(), patterns like \bförsvarsutgifter\b / \bforskningsutgifter\b will miss common inflected forms (e.g. försvarsutgifterna, forskningsutgifterna) due to the trailing word-boundary. Consider matching on the stem (e.g. försvarsutgift / forskningsutgift) or relaxing the end boundary so plural/definite forms are detected too.

Suggested change

/\bförsvarsutgifter\b/i, // Swedish: defense expenditure

/\bforskningsutgifter\b/i, // Swedish: R&D expenditure

/\bförsvarsutgift/i, // Swedish: defense expenditure (försvarsutgift, försvarsutgifter, försvarsutgifterna, etc.)

/\bforskningsutgift/i, // Swedish: R&D expenditure (forskningsutgift, forskningsutgifter, forskningsutgifterna, etc.)

Fixed in a75983e. Changed /\bförsvarsutgifter\b/i → /\bförsvarsutgift/i and /\bforskningsutgifter\b/i → /\bforskningsutgift/i to match the stem, covering definite/plural forms (försvarsutgifterna, forskningsutgifterna, etc.). Added a test should detect Swedish inflected forms (definite, plural) for these patterns.

Copilot · 2026-02-28T04:55:45Z

.github/copilot-mcp.json

+        "-y",
+        "@smithery/cli@latest",
+        "run",
+        "@anshumax/world_bank_mcp_server"
+      ],


The new MCP server config uses npx -y @smithery/cli@latest run @anshumax/world_bank_mcp_server which pulls whatever versions are current at runtime. For reproducibility and supply-chain risk reduction, consider pinning both packages to explicit versions (and updating them deliberately via dependency bumps).

Fixed in a75983e. Pinned @smithery/cli to 4.4.0. Note: @anshumax/world_bank_mcp_server is a Python package (v0.1.0) hosted on Smithery's registry — it doesn't support npm-style version pinning in the run command. The @smithery/cli version pin controls the client-side tooling.

pethers · 2026-02-28T05:22:02Z

@copilot apply changes based on the comments in this thread

…wedish inflections, pin versions - Sort getIndicator() results by date descending (most recent first) - Change WorldBankDataPoint.value type from `number | null` to `number` - Guard findRelevantIndicators() against empty/whitespace queries - Fix Swedish word patterns to match inflected forms (försvarsutgifterna, etc.) - Pin @smithery/cli to v4.4.0 for supply-chain safety - Add 4 new tests covering sort, empty query, inflected forms Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot · 2026-02-28T05:27:01Z

@copilot apply changes based on the comments in this thread

All 5 review comments addressed in a75983e:

getIndicator() now sorts by date descending
WorldBankDataPoint.value type narrowed to number
findRelevantIndicators() guards against empty/whitespace
Swedish patterns match inflected forms (stem-based matching)
@smithery/cli pinned to 4.4.0

4 new tests added, 2106 total passing.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

registry.smithery.ai
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

github-actions · 2026-02-28T05:29:41Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Initial plan

9e7b3d8

Copilot AI assigned Copilot and pethers Feb 28, 2026

Copilot started work on behalf of pethers February 28, 2026 04:33 View session

Fix code review feedback: remove duplicate section heading, clarify r…

a6f5a27

…egex comment Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Analyze use of world_bank_mcp_server for news generation~~ Integrate World Bank MCP server for economic context in news generation Feb 28, 2026

Copilot finished work on behalf of pethers February 28, 2026 04:50

Merge branch 'main' into copilot/analyze-news-generation-improvements

10eee86

pethers requested a review from Copilot February 28, 2026 04:50

Copilot started reviewing on behalf of pethers February 28, 2026 04:51 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

Copilot started work on behalf of pethers February 28, 2026 05:22 View session

Copilot finished work on behalf of pethers February 28, 2026 05:29

pethers requested a review from Copilot February 28, 2026 05:38

Copilot started reviewing on behalf of pethers February 28, 2026 05:38 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

pethers marked this pull request as ready for review February 28, 2026 05:42

pethers approved these changes Feb 28, 2026

View reviewed changes

		/\bförsvarsutgifter\b/i, // Swedish: defense expenditure
		/\bforskningsutgifter\b/i, // Swedish: R&D expenditure

Conversation

Copilot AI commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2026

🏷️ Automatic Labeling Summary

Label Categories

Uh oh!

github-actions bot commented Feb 28, 2026

🔍 Lighthouse Performance Audit

Uh oh!

github-actions bot commented Feb 28, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

pethers commented Feb 28, 2026

Uh oh!

Copilot AI commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions bot commented Feb 28, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 28, 2026 •

edited

Loading

Copilot AI commented Feb 28, 2026 •

edited

Loading