Skip to content

Conversation

@max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Sep 7, 2025

…ort pages; update 404.html to simplify messaging
@tunetheweb
Copy link
Member

A you add | grep -v 404 to this line so it doesn’t try to run that in Lighthouse?

@max-ostapenko
Copy link
Contributor Author

@tunetheweb which line?

@tunetheweb
Copy link
Member

Oops. Forgot to paste that!

CHANGED_FILES=$(git diff --name-only "main...${COMMIT_SHA}" --diff-filter=d templates config/reports.json | grep -v base.html | grep -v main.html | grep -v ejs | grep -v base_ | grep -v sitemap | grep -v error.html | grep -v techreport/components | grep -v techreport/templates | grep -v techreport/report | grep -v techreport/techreport)

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-ostapenko max-ostapenko merged commit a2847f8 into main Sep 7, 2025
11 checks passed
@max-ostapenko max-ostapenko deleted the cold-crab branch September 7, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants