Skip to content

Fix page weight and console bugs #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tunetheweb merged 2 commits into from
Aug 18, 2025
Merged

Fix page weight and console bugs #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
100f51a
Fix page weight bug
tunetheweb Aug 18, 2025
579da01
Add checks to prevent console errors
tunetheweb Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions config/techreport.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,35 +580,35 @@
"cards": [
{
"endpoint": "pageWeight",
"category": "images",
"category": "total",
"metric": "median_bytes_formatted",
"label": "Image Weight",
"url": "?weight-over-time=image#page-weight",
"label": "Total Page Weight",
"url": "?weight-over-time=total#page-weight",
"change": "true",
"changeMeaning": "inverted"
},
{
"endpoint": "pageWeight",
"category": "js",
"category": "images",
"metric": "median_bytes_formatted",
"label": "JavaScript Size",
"url": "?weight-over-time=js#page-weight",
"label": "Image Weight",
"url": "?weight-over-time=image#page-weight",
"change": "true",
"changeMeaning": "inverted"
},
{
"endpoint": "pageWeight",
"category": "total",
"category": "js",
"metric": "median_bytes_formatted",
"label": "Total Page Weight",
"url": "?weight-over-time=total#page-weight",
"label": "JavaScript Size",
"url": "?weight-over-time=js#page-weight",
"change": "true",
"changeMeaning": "inverted"
}
]
},
"weight_timeseries": {
"title": "Weight over time",
"title": "Median page weight over time",
"description": "",
"id": "weight_timeseries",
"summary": true,
Expand Down Expand Up @@ -666,8 +666,8 @@
"viz": {
"base": "median_bytes_",
"param": "weight-over-time",
"default": "images",
"title": "Image weight over time",
"default": "total",
"title": "Weight over time",
"metric": "median_bytes",
"suffix": "bytes",
"metric_summary": "median_bytes_formatted",
Expand Down Expand Up @@ -1026,7 +1026,7 @@
}
},
"weight_timeseries": {
"title": "Page weight over time",
"title": "Total page weight",
"description": "",
"id": "weight_timeseries",
"endpoint": "pageWeight",
Expand Down
2 changes: 1 addition & 1 deletion src/js/techreport/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ class TechReport {
// Update drilldown page components
updateDrilldownComponents(data) {
const app = this.filters.app[0];
const icon = data[app].at(-1).icon;
const icon = data[app]?.at(-1)?.icon;
DrilldownHeader.update(this.filters);
DrilldownHeader.setIcon(`${encodeURI(icon)}`);

Expand Down
2 changes: 1 addition & 1 deletion src/js/techreport/timeseries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class Timeseries {
} else {
/* Add the value to the wrapper */
const valueLabel = document.createElement('p');
valueLabel.textContent = `${latestValue.toLocaleString()}${breakdown.suffix || ''}`;
valueLabel.textContent = `${latestValue?.toLocaleString()}${breakdown.suffix || ''}`;
valueLabel.classList.add('breakdown-value');
itemWrapper.appendChild(valueLabel);
}
Expand Down
2 changes: 1 addition & 1 deletion templates/techreport/drilldown.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ <h3>{{ tech_report_page.config.weight_summary.title }}</h3>

<div class="card">
{% set timeseries = tech_report_page.config.weight_timeseries %}
{% set selected_subcategory = request.args.get('weight-over-time', '') or tech_report_page.config.weight_timeseries.viz.default or 'performance' %}
{% set selected_subcategory = request.args.get('weight-over-time', '') or tech_report_page.config.weight_timeseries.viz.default or 'total' %}
{% include "techreport/components/timeseries.html" %}
</div>
</div>
Expand Down
Loading