Set OMI observation type switches from EnKF input file#60
Open
jjokella wants to merge 11 commits intotsmp-pdaf-patched-omifrom
Open
Set OMI observation type switches from EnKF input file#60jjokella wants to merge 11 commits intotsmp-pdaf-patched-omifrom
jjokella wants to merge 11 commits intotsmp-pdaf-patched-omifrom
Conversation
All observation-type calls in the OMI callback routines are now conditionally executed via IF (assim_GRACE) / IF (assim_SM) guards. The commented-out observation type C is updated to the same pattern throughout all subroutines.
used variables of the same name can be found inside the OMI-modules.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jjokella
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
also: commented out C obstype templates everywhere
jjokella
changed the title
s7yoewer
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I hid all previous comments and "restart" the PR based on the discussion in the meeting in Bonn on March 27, 2026.
Bottom line of the Bonn-meeting:
assim_*flags are not strictly needed as the observation type information in the observation files determine which functions from the OMI-callback routine are actually called.assim_*flags based on input fromenkfpf.par, as a "double-check" of inputs and to have a text-file and human-readable input inside a given run-directory that expresses which observation types are updated in the simulation experiment in question.Notes about the Implementation
Fixing
assim_*at the beginning of the simulation ininit_pdaf.F90based on the inputsclmupdate_*from theenkfpf.par.Fixing
assim_*during runtime is dangerous, because theclmupdate_*are updated at every timestep according to the observation type in the observation file.Minor points in PR
Cthroughout the implementation.rms_obs_*variables frommod_assimilation