Conversation
The goal is to create slope files for ParFlow. This tools should be able to do that.
This should be consistent with the ParFlow overland flow boundary condition.
This is calls PriorityFlow::SlopeCalStan() with the right arguments, but ParFlow needs PriorityFlow::SlopeCalcUP().
Slopes in x- and y-direction appear okay, except that the right half of both variables are sort of a ghost mirror image of the left half. Figure out at which step this happens.
Handling of arguments in R and Python
I am not certain if this is relevant, as I've found out that the script (also in its previous form) does nothing to HSURFBurned.nc, i.e. the values of HSURFBurnedAndMod are identical to HSURFBurned.
N.B. This still uses PriorityFlow::SlopeCalStan() and should use PriorityFlow::SlopeCalcUP() for ParFlow. Also direction based on non-burnt DEM should be used in the calculation. Resolves: #10
This should be the opposite of netCDF2simpleASCII.py
N.B. This does not generate the expected slopes! Does not resolve #10 + Use pysheds to fill pits + Use GDAL for conversion between GeoTIFF and netCDF
Apparently the mask is upside down; with this patch the mask is applied correctly. This commit resolves Problem 2 of issue #10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculate D4 direction slopes with PriorityFlow.