Skip to content

转化 GameVersion 为 record #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CiiLu wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −84
Open

转化 GameVersion 为 record #6663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f157e6b
(65) 但去尽忠 盼归诉勇
CiiLu Aug 12, 2026
494ee8c
何意味是什么意思
CiiLu Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions HMCLCore/src/main/java/org/jackhuang/hmcl/download/fabric/FabricVersionList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.jackhuang.hmcl.task.Task;
import org.jackhuang.hmcl.util.gson.JsonUtils;
import org.jackhuang.hmcl.util.io.NetworkUtils;
import org.jetbrains.annotations.Nullable;

import java.io.IOException;
import java.util.Collections;
Expand Down Expand Up @@ -68,39 +67,14 @@ public Task<?> refreshAsync() {
private List<String> getGameVersions(String metaUrl) throws IOException {
String json = NetworkUtils.doGet(downloadProvider.injectURLWithCandidates(metaUrl));
return JsonUtils.GSON.fromJson(json, listTypeOf(GameVersion.class))
.stream().map(GameVersion::getVersion).collect(Collectors.toList());
.stream().map(GameVersion::version).collect(Collectors.toList());
}

private static String getLaunchMetaUrl(String gameVersion, String loaderVersion) {
return String.format("https://meta.fabricmc.net/v2/versions/loader/%s/%s", gameVersion, loaderVersion);
}

private static class GameVersion {
private final String version;
private final String maven;
private final boolean stable;
private record GameVersion(String version, String maven, boolean stable) {

public GameVersion() {
this("", null, false);
}

public GameVersion(String version, String maven, boolean stable) {
this.version = version;
this.maven = maven;
this.stable = stable;
}

public String getVersion() {
return version;
}

@Nullable
public String getMaven() {
return maven;
}

public boolean isStable() {
return stable;
}
}
}
30 changes: 2 additions & 28 deletions HMCLCore/src/main/java/org/jackhuang/hmcl/download/legacyfabric/LegacyFabricVersionList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.jackhuang.hmcl.task.Task;
import org.jackhuang.hmcl.util.gson.JsonUtils;
import org.jackhuang.hmcl.util.io.NetworkUtils;
import org.jetbrains.annotations.Nullable;

import java.io.IOException;
import java.util.Collections;
Expand Down Expand Up @@ -71,7 +70,7 @@ public Task<?> refreshAsync() {
private List<String> getGameVersions(String metaUrl) throws IOException {
String json = NetworkUtils.doGet(downloadProvider.injectURLWithCandidates(metaUrl));
return JsonUtils.GSON.fromJson(json, listTypeOf(GameVersion.class))
.stream().map(GameVersion::getVersion).collect(Collectors.toList());
.stream().map(GameVersion::version).collect(Collectors.toList());
}

private static String normalizeVersion(String version) {
Expand All @@ -84,32 +83,7 @@ private static String getLaunchMetaUrl(String gameVersion, String loaderVersion)
return String.format("https://meta.legacyfabric.net/v2/versions/loader/%s/%s", gameVersion, loaderVersion);
}

private static class GameVersion {
private final String version;
private final String maven;
private final boolean stable;
private record GameVersion(String version, String maven, boolean stable) {

public GameVersion() {
this("", null, false);
}

public GameVersion(String version, String maven, boolean stable) {
this.version = version;
this.maven = maven;
this.stable = stable;
}

public String getVersion() {
return version;
}

@Nullable
public String getMaven() {
return maven;
}

public boolean isStable() {
return stable;
}
}
}
30 changes: 2 additions & 28 deletions HMCLCore/src/main/java/org/jackhuang/hmcl/download/quilt/QuiltVersionList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.jackhuang.hmcl.task.Task;
import org.jackhuang.hmcl.util.gson.JsonUtils;
import org.jackhuang.hmcl.util.io.NetworkUtils;
import org.jetbrains.annotations.Nullable;

import java.io.IOException;
import java.util.Collections;
Expand Down Expand Up @@ -68,39 +67,14 @@ public Task<?> refreshAsync() {
private List<String> getGameVersions(String metaUrl) throws IOException {
String json = NetworkUtils.doGet(downloadProvider.injectURLWithCandidates(metaUrl));
return JsonUtils.GSON.fromJson(json, listTypeOf(GameVersion.class))
.stream().map(GameVersion::getVersion).collect(Collectors.toList());
.stream().map(GameVersion::version).collect(Collectors.toList());
}

private static String getLaunchMetaUrl(String gameVersion, String loaderVersion) {
return String.format("https://meta.quiltmc.org/v3/versions/loader/%s/%s", gameVersion, loaderVersion);
}

private static class GameVersion {
private final String version;
private final String maven;
private final boolean stable;
private record GameVersion(String version, String maven, boolean stable) {

public GameVersion() {
this("", null, false);
}

public GameVersion(String version, String maven, boolean stable) {
this.version = version;
this.maven = maven;
this.stable = stable;
}

public String getVersion() {
return version;
}

@Nullable
public String getMaven() {
return maven;
}

public boolean isStable() {
return stable;
}
}
}