Fix #6320: 修复安装新实例时，Fabric API 安装路径未遵循版本隔离策略的问题#6355
Conversation
…ersion handling in repository
…solated instances
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5dd591cd59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| && value.isModLoader() | ||
| && get(value.getPatchId()) instanceof RemoteVersion) { |
There was a problem hiding this comment.
When the user installs only OptiFine with the default isolation mode set to MODDED, OPTIFINE.isModLoader() is false, so this method returns false and applyDefaultIsolationSettingForNewInstance skips creating the per-instance running directory. The previous post-install check used LibraryAnalyzer.isModded(...), which treats OptiFine's LaunchWrapper main class as modded, so OptiFine-only installations now regress to sharing the base .minecraft directory.
Useful? React with 👍 / 👎.
1 participant
No description provided.