feat: 增加高对比度主题#5973
Closed
glowinXD wants to merge 3 commits intoHMCL-dev:mainfrom
Closed
Conversation
glowinXD
commented
Apr 19, 2026
|
|
||
| { | ||
| var contrastPane = new LineSelectButton<String>(); | ||
| contrastPane.setTitle(i18n("settings.launcher.contrast")); |
Contributor
Author
There was a problem hiding this comment.
TODO: 补全 i18n
settings.launcher.contrast
settings.launcher.contrast.default
settings.launcher.contrast.high
Contributor
|
有考虑做一个跟随系统的选项吗？检测到系统启用了高对比度主题时，同步启用 HMCL 的高对比度主题。 |
Member
|
不要这样大量修改无关代码，这会大幅提高审查成本。而且这里还大量把代码修改成和已有代码不一致的风格，把所有有效修改都淹没在无意义的内容中了。 请不要最好修改主题相关的内容，这些是 #5551 的一部分。在 #5551 完成后，相关设置会被包含在主题包之中，允许用户通过切换主题包来切换色彩、背景、对比度、色彩风格等属性。迁移完成后现有主题系统会被放弃，本 PR 会造成迁移成本增加。 由于 #5551 还需要一段时间才能完成，如果本 PR 只有简单有效的修改（只添加一个选项），那我们可以考虑先作为临时方案合并，但这样丢出来一堆对现有代码风格的破坏性修改我们实在没有精力审查。 实现功能前建议先通过 Issue 反馈来记录并认领，不建议这样直接打开 PR，否则可能会导致重复工作。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.