feat: 修改主页下载稳定版功能为在应用内更新#5957
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d01199be97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| RemoteVersion target = UpdateChecker.getLatestVersion(); | ||
| if (target != null) { | ||
| UpdateHandler.updateFrom(target); |
There was a problem hiding this comment.
This callback upgrades from UpdateChecker.getLatestVersion() as soon as checkingUpdate becomes false, but it does not verify that the just-finished check actually fetched a stable result. Because requestCheckUpdate is skipped when another check is already running and latestVersion is left unchanged when a check fails, clicking this link during an in-flight check (or after a failed stable check) can still install a stale dev/nightly version instead of switching to stable.
Useful? React with 👍 / 👎.
|
|
||
| public void onSwitchToStableChannel() { | ||
| Controllers.confirm(i18n("update.switch_to_stable.confirm"), i18n("update.switch_to_stable.title"), () -> { | ||
| UpdateChecker.requestCheckUpdate(UpdateChannel.STABLE, config().acceptPreviewUpdateProperty().get()); |
There was a problem hiding this comment.
The new “switch to stable” flow passes acceptPreviewUpdate into requestCheckUpdate, so users who enabled preview updates will query stable-preview rather than stable. That conflicts with the UI text promising installation of the latest stable version and can keep users on pre-release builds after choosing this action.
Useful? React with 👍 / 👎.
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
3 participants
之前主页中预览版提示下载稳定版是打开HMCL官网的下载地址，但是在HMCL内更新应该是更好的选择
bandicam.2026-04-14.22-53-16-847.mp4