[Feature] 资源包管理 #4980 reforged by Calboot · Pull Request #5774 · HMCL-dev/HMCL

Calboot · 2026-03-12T14:09:45Z

资源包管理界面边框样式修复
修复资源包依赖模组下载错误的问题
资源包启用/禁用功能
资源包详细信息界面
与模组管理界面同步
更新资源包

具体改动

修复了资源包管理界面元素边框过粗的问题
Fixes [Bug] 以资源包前置方式下载模组，模组被错误下载到资源包文件夹 #4680
修复光影包下载对话框标题错误的问题
添加启用/禁用资源包功能（实验性，有警告）
添加资源包详细信息界面
移除资源包删除按钮，改为与模组界面一致的删除逻辑
Fixes [Bug] 实例管理-资源包管理页面有概率无法用esc退回到主界面 #5037
从一些类里抽象出LocalAddonFile和LocalFileManager<T extends LocalAddonFile>，使更新对于模组以外的东西（如资源包和光影包）也能适用，从而实现了资源包更新（不保留旧版本）
Fixes [Bug] 在“下载资源包”页面中，未正确选中当前编辑的版本，且下载存储位置错误。 #5207
让资源包光影包下载也有推荐项
Fixes [Bug] 实例管理 > 资源包管理，进入实例管理页面后，文件夹创建的奇妙行为 #5489

See #4980

在BMC4中测试时发现BMC4会判定所有资源包兼容，与原版表现不符，会导致启用/禁用功能失效，故添加警告

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

…esourcepack-enhancement

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Calboot · 2026-04-03T13:41:37Z

我认为这种信息完全没有意义，模组管理页面也不会显示这种没有意义的东西。

removed

Glavo · 2026-04-03T13:46:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5821e3600

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Glavo · 2026-04-04T13:47:30Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a significant refactoring of the addon management system, establishing a generic base for both mods and resource packs through the LocalAddonFile and LocalAddonManager classes. It replaces the previous resource pack implementation with a more robust system that includes detailed compatibility checks based on PackMcMeta and unified update logic. Review feedback highlights opportunities to improve robustness by logging failures during file deletion, providing user-facing error messages when directory creation fails, and optimizing performance by batching configuration file writes during bulk operations.

3gf8jv4dv · 2026-04-05T05:31:24Z

碎碎念几句。

回顾来看，当时的「撤回」感觉操之过急。

尤其是合并后又突然评论「光顾着看代码了」「合并之后发现还是有很多问题」，给 PR 作者、其他活跃贡献者以及普通用户的观感并不太好。而且撤回理由也很含糊——看到了 mineDiamond 的评论才让人大致明白撤回的一个「动机」。

而且 force push 也不是一个可以随意在默认分支/主分支使用的操作——尤其是对于知名的、有多人协作的项目。这个 PR 也不涉及隐私啥的，哪怕再提交一个 revert commit 也好过 force push。直接 force push，让之前的 PR 看起来「合并」了，但却没有出现在 commit history 中，给其他查阅 commit / issue / PR 的用户带来了困惑和不解。

Glavo · 2026-04-05T12:35:01Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the addon management system by introducing a unified hierarchy for mods and resource packs through the LocalAddonManager and LocalAddonFile classes. It replaces the previous resource pack implementation with a more robust system that includes compatibility checking and update support for CurseForge and Modrinth. The UI has been updated to use generic components for addon updates and downloads. Review feedback suggests improving the UI by displaying filenames instead of full paths in error dialogs and ensuring consistency by using utility methods for zip file operations.

gemini-code-assist · 2026-04-05T12:37:20Z

+                return i == 0 ? PackMcMeta.PackVersion.UNSPECIFIED : new PackMcMeta.PackVersion(i, 0);
+            }
+        }
+        try (var zipFileTree = new ZipFileTree(CompressingUtils.openZipFile(gameJar))) {


For consistency with other parts of the resource pack management code (e.g., ResourcePackZipFile), consider using the CompressingUtils.openZipTree utility method here.

Suggested change

try (var zipFileTree = new ZipFileTree(CompressingUtils.openZipFile(gameJar))) {

try (var zipFileTree = CompressingUtils.openZipTree(gameJar)) {

Glavo · 2026-04-05T12:44:26Z

资源包管理界面中启用状态好像经常会和游戏中不一致？

3gf8jv4dv · 2026-04-05T18:02:20Z

又看了看 Glavo 给的图，我产生了一种微妙的感觉。

一个资源包条目的两行文字中，除了扩展名以外，两行文字一模一样。
这样的形式真的有意义、有美感吗？

既然目前第一行确定是显示资源包的文件名，那么可以把第二行改成显示 pack.mcmeta 中的 description 字段——这样也与游戏相呼应。

…ement # Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java

Calboot · 2026-04-06T13:40:31Z

既然目前第一行确定是显示资源包的文件名，那么可以把第二行改成显示 pack.mcmeta 中的 description 字段——这样也与游戏相呼应。

Done

3gf8jv4dv · 2026-04-06T16:32:35Z

有些资源包使用 translate 和 fallback 的格式。例如 SodiumTranslations。

{
    "pack": {
        "description": {
            "translate": "sodium.resource_pack.unofficial",
            "fallback": "Unofficial translations for Sodium"
        },
        "pack_format": 15,
        "min_format": 15,
        "max_format": 84,
        "supported_formats": [15, 64]
    }
}

目前这类资源包会使第二行显示为空。

Glavo · 2026-04-17T09:16:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef04e58364

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-17T09:25:28Z

+        if (!resourcePacks.contains(packIdOld) && (supportsNewOptionsFormat || !resourcePacks.contains(packId))) {
+            resourcePacks.add(supportsNewOptionsFormat ? packId : packIdOld);


Prevent duplicate pack IDs when enabling resource packs

The enable guard uses supportsNewOptionsFormat || !resourcePacks.contains(packId), which is always true on 1.13+ once packIdOld is absent. That means invoking enable on an already-enabled pack appends duplicate file/... IDs to resourcePacks. Since disableResourcePack removes only one occurrence, users can end up with packs that remain enabled after a disable action if they were enabled multiple times (for example via bulk-enable on already enabled selections).

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-17T09:25:28Z

+            modified = true;
+        }
+        if (!incompatibleResourcePacks.contains(packIdOld) && (supportsNewOptionsFormat || !incompatibleResourcePacks.contains(packId)) && isIncompatible(resourcePack)) {
+            incompatibleResourcePacks.add(packId);


Write legacy incompatible IDs without the file/ prefix

For legacy options format (supportsNewOptionsFormat == false), this path still writes packId (file/<name>) into incompatibleResourcePacks instead of the legacy <name> format. In the same class, isEnabled only checks the unprefixed ID when running in legacy mode, so incompatible packs can be misclassified and options.txt is saved in a format older versions do not consistently interpret.

Useful? React with 👍 / 👎.

EDP2021-C1 · 2026-04-20T14:16:47Z

@Calboot 这个账号被封了，暂时更新不了该pr :(

Glavo · 2026-04-21T14:06:01Z

@copilot resolve the merge conflicts in this pull request

Glavo · 2026-04-24T12:51:12Z

@codex resolve the merge conflicts in this pull request

chatgpt-codex-connector · 2026-04-24T12:52:17Z

Codex couldn't complete this request. Try again later.

…ement # Conflicts: # HMCL/src/main/resources/assets/css/root.css # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ModManager.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/curse/CurseAddon.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modrinth/ModrinthRemoteModRepository.java

Glavo

这些意见来自 Codex。

我在当前 PR head 3a0beb047c7c86c94afdcab003b6ea165e0611df 上做了静态审查。下面几处会造成资源包启用状态或删除行为与用户预期不一致，建议修正后再合并。

另有一个较小问题：HMCLCore/src/main/java/org/jackhuang/hmcl/mod/modinfo/PackMcMeta.java 中 pack.description 为对象时只解析 text 和 extra，没有处理 Minecraft 文本组件常见的 translate + fallback。这类资源包会在列表和详情页显示空描述，也无法通过 fallback 文本被搜索到。

Glavo · 2026-04-26T13:55:24Z

+        String packId = "file/" + resourcePack.getFileNameWithExtension();
+        String packIdOld = resourcePack.getFileNameWithExtension();
+        boolean modified = false;
+        if (!resourcePacks.contains(packIdOld) && (supportsNewOptionsFormat || !resourcePacks.contains(packId))) {


[P1] supportsNewOptionsFormat || !resourcePacks.contains(packId) 在 1.13+ 恒为 true，已启用的 file/<name> 资源包再次执行启用时会重复 append 到 resourcePacks。disableResourcePack 只 remove 一次，重复启用后用户点禁用仍会残留条目，游戏里资源包继续处于启用状态。

Glavo · 2026-04-26T13:55:24Z

+            modified = true;
+        }
+        if (!incompatibleResourcePacks.contains(packIdOld) && (supportsNewOptionsFormat || !incompatibleResourcePacks.contains(packId)) && isIncompatible(resourcePack)) {
+            incompatibleResourcePacks.add(packId);


[P2] 旧格式 options（supportsNewOptionsFormat == false）下，resourcePacks 写的是 packIdOld，但不兼容列表仍写入 packId（file/<name>）。后面的 isEnabled 在旧格式下只认可 packIdOld，所以 1.6.1 到 1.12.2 的不兼容资源包启用后会被 UI 判定为未启用，并且保存出旧版本不一致的 options.txt。

Glavo · 2026-04-26T13:55:24Z

+        boolean modified = false;
+        for (ResourcePackFile resourcePack : resourcePacks) {
+            if (resourcePack != null && resourcePack.manager == this) {
+                resourcePack.delete();


[P2] 删除资源包只删除文件和 localFiles，没有同步移除 options.txt 里的 resourcePacks / incompatibleResourcePacks 条目。用户删除已启用资源包后配置仍保留旧 ID；之后重新放回同名资源包会被自动视为已启用，造成删除行为和后续游戏状态不一致。

Calboot and others added 30 commits December 14, 2025 10:32

修复资源包管理界面边框样式问题

652491c

修复 HMCL-dev#4680

2bc3fa7

update

c5406e3

修复光影包界面下载标题错误

facdd47

资源包启用/禁用功能

d24b7b2

同步模组管理界面 Part1

a2b5e8b

为不兼容资源包添加警告

2ca2f3e

update

ce9377b

启用/禁用资源包时添加警告

bd96337

在BMC4中测试时发现BMC4会判定所有资源包兼容，与原版表现不符，会导致启用/禁用功能失效，故添加警告

资源包详细信息界面

bc229e3

修复esc键失效

777aea3

Update i18n

e7c4f2e

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update i18n

07a9cc0

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

完善资源包版本解析

9aca021

Merge remote-tracking branch 'origin/resourcepack-enhancement' into r…

eacf26b

…esourcepack-enhancement

从模组管理界面同步

8d44424

update

00b377a

update i18n

7d2ea79

移除资源包删除按钮

8ba09cf

Merge branch 'HMCL-dev:main' into resourcepack-enhancement

ae789fb

添加cf/modrinth页面检测 & fix i18n

9f6f42b

Apply suggestions

9172c53

update i18n

7ab6e62

Apply suggestions from code review

c7010f9

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Apply suggestions from code review

b0fca8d

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

资源包更新功能

78b5ce7

update

6709fbe

update

07632bb

update

6a6a07d

update

827272e

update

a5821e3

chatgpt-codex-connector Bot reviewed Apr 3, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java Outdated

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ModManager.java Outdated

apply suggestions

6c46cb4

gemini-code-assist Bot reviewed Apr 4, 2026

View reviewed changes

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/AddonUpdatesPage.java

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcePackListPage.java Outdated

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/resourcepack/ResourcePackManager.java Outdated

优化IO性能&日志

a862f77

This comment was marked as resolved.

Sign in to view

Calboot added 2 commits April 5, 2026 16:03

update i18n

36b27a8

Fix HMCL-dev#5489 again

02146bc

gemini-code-assist Bot reviewed Apr 5, 2026

View reviewed changes

Fix old format options.txt

5826267

Calboot added 2 commits April 6, 2026 17:20

update cell subtitle

f0fcfd7

Merge remote-tracking branch 'upstream/main' into resourcepack-enhanc…

ef04e58

…ement # Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java

chatgpt-codex-connector Bot reviewed Apr 17, 2026

View reviewed changes

Glavo requested changes Apr 26, 2026

View reviewed changes

	try (var zipFileTree = new ZipFileTree(CompressingUtils.openZipFile(gameJar))) {
	try (var zipFileTree = CompressingUtils.openZipTree(gameJar)) {

		if (!resourcePacks.contains(packIdOld) && (supportsNewOptionsFormat \|\| !resourcePacks.contains(packId))) {
		resourcePacks.add(supportsNewOptionsFormat ? packId : packIdOld);

Conversation

Calboot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Calboot commented Apr 3, 2026

Uh oh!

Glavo commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Glavo commented Apr 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

3gf8jv4dv commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Glavo commented Apr 5, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Glavo commented Apr 5, 2026

Uh oh!

3gf8jv4dv commented Apr 5, 2026

Uh oh!

Calboot commented Apr 6, 2026

Uh oh!

3gf8jv4dv commented Apr 6, 2026

Uh oh!

Glavo commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

EDP2021-C1 commented Apr 20, 2026

Uh oh!

Glavo commented Apr 21, 2026

Uh oh!

Glavo commented Apr 24, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 24, 2026

Uh oh!

Glavo left a comment

Choose a reason for hiding this comment

Uh oh!

Glavo Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Glavo Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Glavo Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Calboot commented Mar 12, 2026 •

edited

Loading

3gf8jv4dv commented Apr 5, 2026 •

edited

Loading