fix: scope time-off reassignment warning per policy type#1683
Merged
jeffredodd merged 1 commit intomainfrom May 5, 2026
Merged
fix: scope time-off reassignment warning per policy type#1683jeffredodd merged 1 commit intomainfrom
jeffredodd merged 1 commit intomainfrom
Conversation
krisxcrash
requested review from
dmortal,
hukid,
jeffredodd and
serikjensen
as code owners
jeffredodd
approved these changes
May 5, 2026
krisxcrash
changed the title
The warning when adding employees to a time-off policy incorrectly
stated employees can only be enrolled in one time-off policy. Per
GWS-flows, the constraint is per policy type — employees can have
both a vacation and a sick policy simultaneously. Updated the warning
to "Any employees currently assigned to another {policyType} policy
will be moved to this policy." with interpolated policy type labels.
jeffredodd
force-pushed
the
kw/fix/time-off-reassignment-warning
branch
from
d64ecee to
61066c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Demo
Related
Testing