feat: push scalar subquery filters into scans - #29
Open
discord9 wants to merge 3 commits into
Open
Conversation
Signed-off-by: discord9 <55937128+discord9@users.noreply.github.com>
Signed-off-by: discord9 <55937128+discord9@users.noreply.github.com>
Signed-off-by: discord9 <55937128+discord9@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
An uncorrelated scalar subquery is executed and published before DataFusion starts the main input. A physical predicate such as:
can therefore be resolved before scan execution. Snapshotting
ScalarSubqueryExprenables local pruning, but runtime pushdown through execution-plan boundaries requires aDynamicFilterPhysicalExprproducer/consumer relationship.Parquet also retains supported predicates for statistics pruning while reporting
PushedDown::Nowhen row-filter pushdown is disabled. Scalar-subquery bindings must therefore be retained based on the rewritten input actually containing the dynamic-filter expression ID, rather than only the pushdown discriminant.What changes are included in this PR?
PhysicalExpr::snapshot()forScalarSubqueryExpr.ScalarSubqueryExec:Column >= ScalarSubqueryExpr - Literalpredicates scoped to its ownScalarSubqueryResults;ScalarSubqueryExecNodegains repeated binding records containing the producer predicate and consumer expression ID.This keeps the existing scalar-subquery execution order: all scalar subqueries finish before the main input starts. It does not rewrite the query to a nested-loop join, execute streams concurrently, or add a new datasource protocol.
Are these changes tested?
Yes. The following focused checks pass:
Are there any user-facing changes?
Queries with eligible uncorrelated scalar-subquery predicates can now resolve the scalar value before scan execution and deliver the resulting dynamic predicate to scan pruning. This enables runtime file/row-group pruning and downstream consumers such as GreptimeDB MergeScan without changing SQL semantics or scalar-subquery execution order.