Skip to content

Conversation

@epontan
Copy link
Collaborator

@epontan epontan commented Sep 7, 2025

Due to updated Rust toolchain the new mismatched_lifetime_syntaxes1 lint is temporarily allowed on the generated svd2rust code for all the MCAN registers until the code has been regenerated and customized with a newer svd2rust version.

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All tests pass and in the best case you also added new tests.
  • cargo +stable fmt was run.
  • cargo +stable clippy yields no warnings.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You add a description of your work to this PR.
  • You added proper docs (in code, rustdoc and README.md) for your
    newly added features and code.

Due to updated Rust toolchain the new `mismatched_lifetime_syntaxes`[1]
lint is temporarily allowed on the generated svd2rust code for all the
MCAN registers until the code has been regenerated and customized with a
newer svd2rust version.

[1]: https://doc.rust-lang.org/beta/nightly-rustc/rustc_lint/lifetime_syntax/static.MISMATCHED_LIFETIME_SYNTAXES.html
@epontan epontan requested a review from a team as a code owner September 7, 2025 15:00
@epontan epontan self-assigned this Sep 7, 2025
@Ironedde
Copy link
Contributor

Ironedde commented Sep 8, 2025

Nice, Lets get this in before all the other patches 👍

How do you think we should handle small changes like this. I don't think it makes sense to have a CHANGELOG.md entry for it, do you?

Also, seams like this was fixed in svd2rust 0.37.0, see: rust-embedded/svd2rust#936.

Later, I'll investigate if we can do a big jump from svd2rust 0.30.2, hopefully there shouldn't be anything breaking.

@epontan
Copy link
Collaborator Author

epontan commented Sep 8, 2025

Nice, Lets get this in before all the other patches 👍

How do you think we should handle small changes like this. I don't think it makes sense to have a CHANGELOG.md entry for it, do you?

No, I don't think it is necessary.

Also, seams like this was fixed in svd2rust 0.37.0, see: rust-embedded/svd2rust#936.

Later, I'll investigate if we can do a big jump from svd2rust 0.30.2, hopefully there shouldn't be anything breaking.

Awesome, I have a couple of more small upcoming changes that I would like to get in a release before we lift svd2rust.

@Ironedde
Copy link
Contributor

Ironedde commented Sep 9, 2025

Awesome, I have a couple of more small upcoming changes that I would like to get in a release before we lift svd2rust.

Absolutely, no problem 👍
I might put up a draft PR for it this month, but we'll make sure to get your changes in before that one.

Copy link
Contributor

@Ironedde Ironedde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@epontan epontan merged commit 097f438 into GrepitAB:master Sep 9, 2025
5 checks passed
@epontan epontan deleted the allow-mismatched-lifetime-syntaxes branch September 9, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants