wip adding shilo npc dialogue and shops etc#950
Open
MrSlayerGod wants to merge 9 commits into
Open
Conversation
GregHib
reviewed
Jul 3, 2026
| npc<Quiz>( | ||
| "yohnus_shilo_village", | ||
| "Sorry but the blacksmiths is closed. But I can let you use the furnace at the cost of 20 gold pieces." | ||
| ) |
Owner
There was a problem hiding this comment.
Should probably go to the choice dialogue here or the dialogue should be something different?
Contributor
Author
There was a problem hiding this comment.
Owner
There was a problem hiding this comment.
Yeah the (Continues above.) means it'll show the choice dialogue
Contributor
Author
There was a problem hiding this comment.
what needs to change and what needs to move then thanks ?
Owner
There was a problem hiding this comment.
Pull out the other dialogue into a method:
suspend fun Player.furnace() {
npc<Neutral>("Sorry but the blacksmiths is closed. But I can let you use the furnace at the cost of 20 gold pieces.")
choice {
option<Neutral>("Use Furnace - 20 Gold") {
inventory.transaction {
remove("coins", 20)
}
when (inventory.transaction.error) {
TransactionError.None -> {
this["yohnus_paid"] = true
npc<Happy>("Thanks Bwana! Enjoy the facilities!")
}
else -> npc<Neutral>("Sorry, you don't have enough coins.")
}
}
option<Neutral>("No thanks!") {
player<Neutral>("No thanks!")
npc<Neutral>("Very well Bwana, have a nice day.")
}
}
}And call that here with
talkWith(NPCs.findBySpawn(Tile(2857, 2963), "yohnus_shilo_village")
furnace()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
complete dialogue
Fernahei
WIP dialogue
Yohnus