Conversation
Adds the quest script, the clay golem, Elissa, Curator Haig Halen and
Desert Phoenix interactions, and the supporting object/varbit/sound
definitions.
Names for objects, varbits and sounds follow the cache dumps. Objects
6292/6293-6295/6312-6313 carry the golem-era names for the bookcase,
display case and stairs, but none of them are placed anywhere on the 634
map, so the ids the map actually uses are named after the later content
that reuses them, as with tithe_roof_g in Creature of Fenkenstrain.
Notes on the conversion:
- npc 1907 transforms on golem_clay and object 6310 on the quest varbit,
so handlers register against the transformed ids; registering against
the base never fires.
- 6307/6308 are shared by all four alcoves and 24550 is the empty-case
transform of every museum display, so both handlers check the base
object before acting.
- hasClock("in_combat") does not exist in this engine, so the phoenix's
combat check never fired; it now uses under_attack like Pickpocketing.
- the black mushroom crushing recipe cost no vial while the ink empties
back into one, so it moves into the quest script where the vial is
consumed and the original failure message is kept.
- varbit 346 keeps its existing the_golem name rather than the dump's
golem_a; RugMerchant's questCompleted("the_golem") depends on it.
Quest stage names are invented; everything else comes from the cache
dumps or the original scripts.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Qodana for JVM5 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 16 files with indirect coverage changes @@ Coverage Diff @@
## main #1195 +/- ##
============================================
+ Coverage 43.99% 44.04% +0.04%
- Complexity 10060 10116 +56
============================================
Files 1999 2010 +11
Lines 88164 88804 +640
Branches 14485 14574 +89
============================================
+ Hits 38789 39113 +324
- Misses 43759 44025 +266
- Partials 5616 5666 +50
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One issue: The museum display case is not working; it worked on other server so it may be a different component?