Fix report abuse breaking the chat box#1063
Open
HarleyGilpin wants to merge 1 commit into
Open
Conversation
Opening report abuse in select-player mode (cs2 246) unhooks the chat input key listener (137:55) and sets report mode varc 11. The client's close script (cs2 675) never restores either, so chat stays dead until relog. The restore script (cs2 244) has no client-side callers - the server is expected to run it. Close the interface server-side on submit and run cs2 244 whenever report_abuse closes. Closes GregHib#1061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1061
Problem
After submitting (or cancelling) an abuse report, the reporter couldn't type in chat or press Enter for quick-chat until they relogged.
Root cause (client-side, from the 634 cache cs2 + void-client source)
if_setonkey(137:55, -1)) so keystrokes feed the report screen instead. Script 73 (the removed handler) is what processes all chat typing and Enter.Fix
close_report_abuse) whenever thereport_abuseinterface closes.ReportAbuseinstruction arrives (before validation — the client has already dismissed its side), keeping server interface state in sync and triggering the restore on every path (submit, cancel, X).Testing
ReportAbuseTestcases pass.