Skip to content

Add pitfall traps#1062

Open
GregHib wants to merge 10 commits into
mainfrom
pitfall
Open

Add pitfall traps#1062
GregHib wants to merge 10 commits into
mainfrom
pitfall

Conversation

@GregHib

@GregHib GregHib commented Jul 6, 2026

Copy link
Copy Markdown
Owner
  • Add spined larupia, horned graahk and sabre-toothed kyatt
  • Add pitfall trap setting and catching
  • Add pitfall collapsing
  • Fix bank withdraw message when all items removed
  • Remove duplicate mazchna slayer master
  • Fix barbarian advanced laps reward collection

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Qodana for JVM

1 new problem were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.02521% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.17%. Comparing base (773247d) to head (b3eef97).

Files with missing lines Patch % Lines
...me/src/main/kotlin/content/skill/hunter/Pitfall.kt 64.03% 19 Missing and 22 partials ⚠️
...ontent/area/kandarin/barbarian_outpost/Gunnjorn.kt 0.00% 1 Missing ⚠️
...me/src/main/kotlin/content/entity/combat/Target.kt 0.00% 0 Missing and 1 partial ⚠️
.../kotlin/content/entity/player/bank/BankWithdraw.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...me/src/main/kotlin/content/entity/combat/Combat.kt 72.35% <100.00%> (+0.45%) ⬆️
game/src/main/kotlin/content/skill/melee/Weapon.kt 87.50% <ø> (ø)
...ontent/area/kandarin/barbarian_outpost/Gunnjorn.kt 8.33% <0.00%> (ø)
...me/src/main/kotlin/content/entity/combat/Target.kt 43.75% <0.00%> (-0.40%) ⬇️
.../kotlin/content/entity/player/bank/BankWithdraw.kt 54.76% <0.00%> (ø)
...me/src/main/kotlin/content/skill/hunter/Pitfall.kt 64.03% <64.03%> (ø)

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main    #1062      +/-   ##
============================================
+ Coverage     43.09%   43.17%   +0.08%     
- Complexity     8952     8957       +5     
============================================
  Files          1817     1817              
  Lines         78388    78387       -1     
  Branches      13171    13166       -5     
============================================
+ Hits          33781    33846      +65     
+ Misses        39741    39654      -87     
- Partials       4866     4887      +21     
Components Coverage Δ
Content 43.24% <63.02%> (+0.11%) ⬆️
Engine 45.78% <ø> (ø)
Network 71.37% <ø> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant