Skip to content

AboutControllerTest fails on a JDK whose java.version is exactly "25" (matches Bootstrap w-25) #277

Open

Description

@dfcoffin

Problem

AboutControllerTest.about_is_public_and_shows_product_identity_without_framework_versions in openespi-datacustodian and openespi-thirdparty asserts:

.doesNotContain("Java version", System.getProperty("java.version"))

On a JDK whose java.version is exactly 25 (e.g. Temurin 25 GA in WSL via SDKMAN), the check fails. The About page always contains 25 because its table header cells use the Bootstrap class w-25:

not to contain: ["Java version", "25"]
but found: ["25"]

Found while running the suites for #275. On JDKs reporting 25.0.x the test passes, so it depends on the machine.

Fix

Assert something that can't collide with markup, e.g.:

  • check that the page has no Java or Spring Boot version row (label text), and
  • check for the full version only when it is distinctive (contains a .), or match it as visible text (Jsoup / a regex over text content) instead of raw HTML.

Apply the same fix to both modules' AboutControllerTest (DC line 56, TP line 57).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions