Fall back to a generated telemetry event name when creating new widget (7.0) - #27166
Open
dennisoelkers wants to merge 1 commit into
Open
Fall back to a generated telemetry event name when creating new widget (7.0)#27166dennisoelkers wants to merge 1 commit into
7.0)#27166dennisoelkers wants to merge 1 commit into
Conversation
…tModal The dashboard "+" create-widget modal looked up the telemetry event name for a widget type directly in TELEMETRY_EVENT_TYPE.SEARCH_WIDGET_CREATE with no fallback. Since that map only defines 4 of the registered widget types, creating a Custom Aggregation, Events Overview, or Text/Markdown widget (or any plugin-provided widgetCreator not in the map) sent sendTelemetry(undefined, ...). Mirror the fallback already used by the sibling AddWidgetButton component. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #27164 to
7.0.Description
Motivation and Context
The dashboard "+" create-widget modal looked up the telemetry event name for a widget type directly in TELEMETRY_EVENT_TYPE.SEARCH_WIDGET_CREATE with no fallback. Since that map only defines 4 of the registered widget types, creating a Custom Aggregation, Events Overview, or Text/Markdown widget (or any plugin-provided widgetCreator not in the map) sent sendTelemetry(undefined, ...). Mirror the fallback already used by the sibling
AddWidgetButtoncomponent./nocl No user-facing change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: