Skip to content

Add per entity permission checks to Notification Test endpoint#26614

Merged
ryan-carroll-graylog merged 2 commits into
masterfrom
14753-notification-test-permissions
Jul 9, 2026
Merged

Add per entity permission checks to Notification Test endpoint#26614
ryan-carroll-graylog merged 2 commits into
masterfrom
14753-notification-test-permissions

Conversation

@ryan-carroll-graylog

@ryan-carroll-graylog ryan-carroll-graylog commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

Adds entity-level permission check to event notification test endpoint which is the same checks that the /events/notifications/{notificationId}/test uses.

Motivation and Context

Closes: https://github.com/Graylog2/graylog-plugin-enterprise/issues/14753

How Has This Been Tested?

Verify that a user cannot test a notification they do not have edit permission for.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@danotorrey danotorrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests successfully.

@ryan-carroll-graylog ryan-carroll-graylog merged commit ad64d89 into master Jul 9, 2026
30 of 32 checks passed
@ryan-carroll-graylog ryan-carroll-graylog deleted the 14753-notification-test-permissions branch July 9, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants