Fixing disabled styling of search submit button.#26592
Open
linuspahl wants to merge 6 commits into
Open
Conversation
Contributor
|
@linuspahl, we have disabled styles while just typing the query. Is that desirable behaviour? |
Contributor
Author
|
Yes, because you can't submit while the query validation is happening. |
maxiadlovskii
approved these changes
Jul 8, 2026
Contributor
|
@linuspahl Ok. My main concern was that the button is blinking while you are typing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The disabled styling for the search submit button is currently missing.
The reason:
The styling has been applied in the
SearchButtonby setting thedisabledclass, instead of thedisabledprop for the button., We did this because we still want to trigger theonClickevent, when the button is disabled to show a dialog which explains why the button is disable. TheonClickevent is usually not being triggered when a button is disabled.The problem is that the button disabled styling is no longer applied via the CSS class in the
Buttoncomponent. I assume since we migrate from react-bootstrap to Mantine.This PR implements a cleaner solution to achieve the desired behavior. We are extending the
Buttoncomponent with a prop that allows to trigger theonClickevent when the button is disabled./prd Graylog2/graylog-plugin-enterprise#14797,Graylog2/e2e-tests#1682
/nocl - fixes a small visual regression