fix: remove benchmark referencing deleted parallel processor#70
Merged
Conversation
… panic StreamCompressor.Reset() could be clobbered by a stale in-flight backgroundCompress goroutine writing its result after the reset, and Close() panicked if called twice due to an unguarded close(done). Add an epoch counter that Reset() bumps; backgroundCompress captures the epoch when it starts and discards its result if the epoch has since changed, making stale writes a no-op instead of an overwrite. Guard Close() with sync.Once so repeated calls are safe. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove BenchmarkParallelProcessor from optimizations_benchmark_test.go which references the deleted parallel.go file.