chore: bump hawk-core-contracts/hawk-mcpkit to v0.1.4#23
Merged
Conversation
hawk's own go.mod already requires hawk-core-contracts v0.1.4 and hawk-mcpkit v0.1.4, so Go's minimal version selection resolves these newer versions into hawk's build regardless of what inspect declares here — meaning inspect's own CI (which only checks go.mod tidiness against its pinned versions) was never actually exercising the versions that ship. Verified both version bumps are non-breaking (diffed the full changesets between v0.1.2->v0.1.4 and v0.1.0->v0.1.4; neither touched a symbol inspect imports). Bumps the declared pin to match what's actually resolved, closing the gap between "safe by luck" and "safe by check."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hawk's own go.mod requireshawk-core-contracts@v0.1.4, so Go's minimal version selection resolves that into hawk's build regardless of what inspect declares — meaning inspect's own CI (go.mod tidiness check only) never actually exercised the version that ships. Bumps the declared pin to match.(Correction from an earlier draft of this description:
hawk-mcpkitdoes not currently enter hawk's build graph at all — hawk only imports the top-levelinspect/sightpackages, never theirmcpsubpackages that use mcpkit, so it never appears in hawk's go.sum. Thehawk-mcpkitbump here is still good hygiene — it keeps inspect testing against its own latest shared dependency — but isn't closing a hawk-build-graph gap the way thehawk-core-contractsbump is.)Verified non-breaking: diffed the full changesets v0.1.2→v0.1.4 (hawk-core-contracts) and v0.1.0→v0.1.4 (hawk-mcpkit) — neither touched a symbol inspect imports (only
types/verifyandmcpkit.Server/New/StrArg/JSONResult).Test plan
go build ./... && go test ./...green locally