Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion engine/selection.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ func (e *Engine) EffectiveSelection(ctx context.Context, opts SelectionOptions)
active := e.ActiveSelection(ctx)
provider := NormalizeProviderID(active.Provider)
model := strings.TrimSpace(active.Model)
hasProviderOverride := false
if override := NormalizeProviderID(opts.ProviderOverride); override != "" {
if override != provider && strings.TrimSpace(opts.ModelOverride) == "" {
model = ""
}
provider = override
hasProviderOverride = true
}
if override := strings.TrimSpace(opts.ModelOverride); override != "" {
model = override
Expand All @@ -53,7 +55,7 @@ func (e *Engine) EffectiveSelection(ctx context.Context, opts SelectionOptions)
if provider == "" && hasConfigured {
provider = preferredConfiguredGateway(gateways, configured)
}
if provider != "" && hasConfigured && !configured[provider] {
if provider != "" && hasConfigured && !configured[provider] && !hasProviderOverride {
provider = preferredConfiguredGateway(gateways, configured)
model = ""
}
Expand Down
23 changes: 23 additions & 0 deletions engine/selection_contract_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,29 @@ func TestEffectiveSelectionClearsModelWhenProviderOverrideChanges(t *testing.T)
}
}

func TestEffectiveSelectionPreservesUnconfiguredProviderOverride(t *testing.T) {
ctx := context.Background()
store := &credentials.MapStore{}
if err := store.Set(ctx, credentials.AccountForEnv("CLINE_API_KEY"), "cline-live-secret-1234567890"); err != nil {
t.Fatal(err)
}
eng, err := New(Options{SecretStore: store, StateDir: t.TempDir()})
if err != nil {
t.Fatal(err)
}

selection := eng.EffectiveSelection(ctx, SelectionOptions{
ProviderOverride: "anthropic",
ModelOverride: catalog.ClaudeOpusV4_6,
})
if selection.Provider != "anthropic" {
t.Fatalf("explicit provider override was replaced by a configured provider: %+v", selection)
}
if !selection.HasConfiguredDeployment {
t.Fatal("configured deployment state was lost while preserving the explicit override")
}
}

func TestCustomProviderOverrideDoesNotReuseOtherCustomModel(t *testing.T) {
ctx := context.Background()
eng, err := New(Options{
Expand Down
Loading