Repository navigation
Resolve :scope in find() against the elements it starts from - #159
Open
gravitypdf-bot wants to merge 5 commits into
Open
gravitypdf-bot wants to merge 5 commits into
gravitypdf-bot wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… one path Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ore sorting Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
============================================
+ Coverage 90.69% 91.31% +0.62%
- Complexity 1424 1455 +31
============================================
Files 25 26 +1
Lines 3170 3214 +44
============================================
+ Hits 2875 2935 +60
+ Misses 295 279 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133. Behaviour change.
:scopeinfind(),findInPlace(),remove($selector)and theqp($node, $selector)constructor now refers to the element the search starts from, including inside:not()and:matches(). Before, it always referred to the document element, soqp($xml, 'ul')->find(':scope > li')matched nothing.How it works:
:scope.:scope: the search runs from each element in turn, as jQuery'sfind()does, and the results are merged in document order. Positional pseudo-classes then count per element.:scope: one search over the set, as before.Util::selectorUsesScope()makes the:scopecheck, and it shares a memoized parse helper withselectorHasPositionalPseudoClass().filter()andis()are unchanged.PseudoClass::is()andisNot()take a new optional$scopeargument, so a subclass that overrides either one must add it.Tests
tests/Issues/Issue133Test.phpcovers the issue's examples, multi-element sets,findInPlace(), the constructor,remove($selector),:has()keeping its own scope, andselectorUsesScope().Merge notes
matchescase inPseudoClass::elementMatches()conflicts: keepcase 'matches': case 'is': case 'where':with the$scopeargument.remove()conflicts on one line: keep thefindMatches()call.Every PR in this set adds its CHANGELOG line at the end of
# Unreleased changes, so each one after the first needs a one-line conflict resolved there.🤖 Generated with Claude Code