Repository navigation
Count positional selectors across the document in is(), as jQuery does - #152
Open
gravitypdf-bot wants to merge 4 commits into
Open
gravitypdf-bot wants to merge 4 commits into
gravitypdf-bot wants to merge 4 commits into
Conversation
jQuery's .is() evaluates a positional selector against the document and
tests membership, so is(':first') asks whether the set holds the
document's first element. is() counted within the match set instead,
as filter() does. It now uses NodeMatcher::matchesInDocument().
Fixes #140.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
============================================
+ Coverage 90.69% 91.25% +0.55%
- Complexity 1424 1445 +21
============================================
Files 25 26 +1
Lines 3170 3190 +20
============================================
+ Hits 2875 2911 +36
+ Misses 295 279 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140. Behaviour change.
is()now counts a positional pseudo-class (:first,:eq(),:last, …) across the whole document, as jQuery's.is()does, rather than within the match set. Soqp($xml, '#c')->is(':first')is nowfalse.filter()still counts within the set, which agrees with jQuery's.filter().The check lives in a new
NodeMatcher::matchesAnyInDocument(). A selector with no positional pseudo-class still takes the single pass over the set that it took before.DOMNodeandSplObjectStoragearguments are unchanged.Tests
tests/Issues/Issue140Test.phpcovers the issue's table against jQuery 3.7.1, plus non-positional selectors, non-element nodes and thefilter()contrast.Every PR in this set adds its CHANGELOG line at the end of
# Unreleased changes, so each one after the first needs a one-line conflict resolved there.🤖 Generated with Claude Code