Repository navigation
Count negative indexes from the end in eq(), get() and slice(), and take an end index in slice() - #149
Open
gravitypdf-bot wants to merge 4 commits into
Open
Count negative indexes from the end in eq(), get() and slice(), and take an end index in slice()#149gravitypdf-bot wants to merge 4 commits into
gravitypdf-bot wants to merge 4 commits into
Conversation
getNthMatch() returned nothing for a negative index, so eq(-1) was empty and get(-1) NULL, and slice() kept every match from a negative start. As in jQuery, a negative index now counts back from the end of the set. Fixes #142. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slice($start, $length) followed array_slice(), with a length of 0 meaning "to the end". It is now slice($start, $end), as in jQuery: the slice stops before $end, a negative $end counts back from the end, and an omitted $end runs to the end of the set. Fixes #144. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
============================================
+ Coverage 90.69% 91.25% +0.56%
- Complexity 1424 1438 +14
============================================
Files 25 26 +1
Lines 3170 3180 +10
============================================
+ Hits 2875 2902 +27
+ Misses 295 278 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142 and #144. They share a PR because both rewrite
slice().#142: negative indexes
eq(),get()andslice()count a negative index back from the end, as jQuery does.DOM::getNthMatch()andslice()resolve it withUtil::normalizePositionalIndex(), the helper:eq()already uses. That helper is now public. An index still out of range gives an empty set, orNULLfromget().#144:
slice($start, $end)— breaking changeThe second argument is now an exclusive end index, as in jQuery, instead of a length:
slice(1, 3)returns two matches, where it used to return three.$endcounts back from the end.0now gives an empty set; it used to mean "to the end".slice($start, $start + $length).Tests
tests/Issues/Issue142Test.phpandIssue144Test.phpcover each issue's table against jQuery 3.7.1.DOMQueryTest::testSlicenow passesslice(1, 3)instead ofslice(1, 2).Every PR in this set adds its CHANGELOG line at the end of
# Unreleased changes, so each one after the first needs a one-line conflict resolved there.🤖 Generated with Claude Code