Stop flatten_graphic_list() from adding unused attributes#4220
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the flatten_graphic_list function in graphic.rs to ensure that parent attributes (such as transform, opacity, fill, and layer path) are only composed onto children if the parent actually carries those attributes. This prevents the flattening process from inventing attribute columns that neither the parent nor the child originally possessed. Additionally, unit tests have been added to verify this behavior. There are no review comments to address, and the changes look solid.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
9a6ced8 to
9e402d3
Compare
After a node such as Flatten Vector, we don't have
transform,opacity,opacity_fill, etc. being added as attributes that were not part of the input data.