Skip to content

Stop flatten_graphic_list() from adding unused attributes#4220

Merged
Keavon merged 1 commit into
masterfrom
fix-spurrious-attributes-on-flatten
Jun 10, 2026
Merged

Stop flatten_graphic_list() from adding unused attributes#4220
Keavon merged 1 commit into
masterfrom
fix-spurrious-attributes-on-flatten

Conversation

@Keavon

@Keavon Keavon commented Jun 10, 2026

Copy link
Copy Markdown
Member

After a node such as Flatten Vector, we don't have transform, opacity, opacity_fill, etc. being added as attributes that were not part of the input data.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the flatten_graphic_list function in graphic.rs to ensure that parent attributes (such as transform, opacity, fill, and layer path) are only composed onto children if the parent actually carries those attributes. This prevents the flattening process from inventing attribute columns that neither the parent nor the child originally possessed. Additionally, unit tests have been added to verify this behavior. There are no review comments to address, and the changes look solid.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon force-pushed the fix-spurrious-attributes-on-flatten branch from 9a6ced8 to 9e402d3 Compare June 10, 2026 20:38
@Keavon Keavon merged commit a7171f5 into master Jun 10, 2026
10 checks passed
@Keavon Keavon deleted the fix-spurrious-attributes-on-flatten branch June 10, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant