Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements Grab and Scale transformation support for the Artboard tool by tracking original bounds and applying custom resizing logic within the transform handler. Feedback indicates that the current implementation breaks numerical and keyboard-constrained transformations because artboards are skipped in the generic transformation path. Additionally, artboards are not correctly reverted to their original state when switching between transformation operations (e.g., from Grab to Scale), leading to inconsistent behavior compared to regular layers.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added artboard tool support to the transform system so you can actually use the G/S (grand and scale) key binds for the artboard. Changing the artboard wont change the other things inside of it. Closes #4026
Changes Made:
transformation.rs - Added Artboard to the tool type checks so it skips the normal transform logic when using the Artboard tool
transform_layer_message_handler.rs - Made artboards filterable and gave them special handling. Also clears everything on cancel/finish.
Graphite.mp4