fix: Path tool requires a double click to insert a new point after having dragged another point

[Annonnymmousss]

closes https://discord.com/channels/731730685944922173/881073965047636018/1419544936986185838

supercede #3631

[gemini-code-assist]

Summary of Changes

Hello @Annonnymmousss, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific usability bug within the Path tool, preventing an unintended interaction where users had to double-click to add new points after performing a drag operation. The fix ensures a smoother and more intuitive workflow for path manipulation by correctly resetting an internal state.

Highlights

• Path Tool Bug Fix: Resolved an issue where the Path tool incorrectly required a double-click to insert a new point after dragging an existing one, by ensuring the molding_segment state is properly reset upon returning to the ready state.

Changelog

• editor/src/messages/tool/tool_messages/path_tool.rs
  • Reset the molding_segment state to false when the Path tool transitions to the ready state.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug where the path tool would require a double click to insert a new point after dragging another point. This was caused by the molding_segment state not being reset after a drag operation. The change correctly resets this flag. The suggested additional state reset for molding_info has been included to improve robustness and prevent similar issues.

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="editor/src/messages/tool/tool_messages/path_tool.rs">

<violation number="1" location="editor/src/messages/tool/tool_messages/path_tool.rs:2640">
P2: Missing reset of `temporary_adjacent_handles_while_molding`. Every other location that resets `molding_segment` and `molding_info` also resets this field (lines 2381, 2504). Omitting it here could leave stale handle data that affects overlay drawing or subsequent molding operations.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}