Desktop: Auto-fallback to non-accelerated UI when CEF texture fails at startup#3772
Closed
JustJ01 wants to merge 2 commits intoGraphiteEditor:masterfrom
Closed
Desktop: Auto-fallback to non-accelerated UI when CEF texture fails at startup#3772JustJ01 wants to merge 2 commits intoGraphiteEditor:masterfrom
JustJ01 wants to merge 2 commits intoGraphiteEditor:masterfrom
Conversation
Contributor
Author
|
@Keavon pls review! |
Member
|
Sorry @JustJ01 we decided against this approach, as we will need restart functionality for other preferences as well and in the end didn't like the UX of what is described in the issue. For future reference, issues that are already assigned, especially those assigned to the core team, are likely not a good fit for beginners. Assigned issues are generally not available to work on unless otherwise stated. Closing in favor of #3774 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3667
This PR implements an automatic compatibility fallback for desktop startup when accelerated UI fails to render(black screen).
I have changed:
Manual Setup ( Tested on Windows)
Remove-Item "$env:APPDATA\Graphite\startup-settings.ron" -ErrorAction SilentlyContinuecargo run -p graphite-desktop@' ( ui_compatibility_mode: true, ) '@ | Set-Content "$env:APPDATA\Graphite\startup-settings.ron"Launch again:
cargo run -p graphite-desktopExpected: Apps runs in compatibility mode , warning icon appears beside version text in status bar
ui-compatibility: false, to verify it runGet-Content "$env:APPDATA\Graphite\startup-settings.ron"Expected on affected machine:
No CEF texture received within the first second...