Fix Shape tool type dropdown not persisting selection and not excluding Line/Rectangle/Ellipse

[Ayush2k02]

This regression was introduced in #2914 (commit 523132d)

In the SetShape handler, this line was added:
responses.add(ShapeToolMessage::UpdateOptions(ShapeOptionsUpdate:

since the setShape was being called with polygon always , the added UpdateOptions call overwrites options.shape_type

below is the call
responses.add(ShapeToolMessage::SetShape { shape: ShapeType::Polygon });

Below are the two main fixes from this PR

• Remove UpdateOptions from SetShape handler - Now SetShape only updates current_shape and calls update_dynamic_hints directly for hint updates, without touching options.shape_type.
• Add SyncShapeWithOptions message - When activating the Shape tool, sync current_shape to match options.shape_type. This ensures the drawing state matches the dropdown selection, especially when returning from Line/Rectangle/Ellipse alias tools.

Screen.Recording.2026-02-16.at.6.59.52.PM.mov

Fixes the issue from this discussion
https://discord.com/channels/731730685944922173/731738914812854303/1469590633361707204

[Ayush2k02]

[Keavon]

Thanks for fixing these two bugs. But I have a concern, which is that your implementation involved new logic, when in both cases, this already used to work and they each broke as a regression at some point in the past few months. I would expect an implementation should track down what broke and then fix what existing logic already performed the functionality for these two issues, rather than leaving behind the other logic in some unknown state and building new logic. Could you please spend some time to go back and check which commit broke both of these issues and post those PRs or commit hashes in a comment here, and then investigate what specific changes within each PR resulted in the regression, and then checking what minimal changes are required to fix the issues and seeing if the ones you did here are redundant?

[Ayush2k02]

Yeah, makes sense to fix that. Let me do that

[Keavon]

Any updates? Just checking how it's going, since this fix will be one of the more important ones to have merged.

[Ayush2k02]

yeah, will get this done today

[Ayush2k02]

#2914

Its this one, from where the bug originated. Can share the bisect logs if you want. I'll fix this now

[Ayush2k02]

Have updated the video and PR description, this is reviewable from my side now

[Keavon]

!build

[github-actions]

📦 Build Complete for fa7f9b5