Skip to content

Add test coverage for paths.nfc() - #2924

Open
hshalwhabi-cpu wants to merge 1 commit into
Graphify-Labs:v8from
hshalwhabi-cpu:test/nfc-coverage
Open

Add test coverage for paths.nfc()#2924
hshalwhabi-cpu wants to merge 1 commit into
Graphify-Labs:v8from
hshalwhabi-cpu:test/nfc-coverage

Conversation

@hshalwhabi-cpu

Copy link
Copy Markdown

Summary

Test plan

  • pytest tests/test_paths.py -v — 50 passed locally

nfc() normalizes path strings to NFC to prevent macOS NFD filenames
from mismatching NFC entries in manifests/graphs (Graphify-Labs#2210, Graphify-Labs#2221/Graphify-Labs#2224),
but had no direct test asserting its behavior.

@graphify-labs graphify-labs Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify reviewed this change.

Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).


Graphify review — findings

Adds a test for nfc in tests/test_paths.py, verifying it normalizes NFD (decomposed) unicode to NFC and leaves already-NFC input unchanged. Imports nfc from graphify.paths.

No blocking issues surfaced.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 13 functions depend on the 13 functions this change touches.

Health — grade A; no new coupling hotspots.

Verification — 13 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 13 function(s) in the blast radius were not formally verified this run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant