fix inverted accuracy check in getOptimalLocation()#637
Open
thomasbuilds wants to merge 1 commit intoGrapheneOS:mainfrom
Open
fix inverted accuracy check in getOptimalLocation()#637thomasbuilds wants to merge 1 commit intoGrapheneOS:mainfrom
thomasbuilds wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Location.getAccuracy()is a radius in meters, smaller is better butgetOptimalLocation()used>in its accuracy tiebreaker, so when two fixes arrived withinSTALE_LOCATION_THRESHOLD(11 s) the less accurate one replaced the more accurate one.The selected
Locationis attached as EXIF GPS data on captured photos and as video metadata when "Save location" is enabled, so the bug silently degrades geotag quality (e.g. a ~500 m network fix overwriting a ~5 m GNSS fix).