Adopt .editorconfig as single source of truth for code style and add formatting CI gate#53
Merged
Merged
Conversation
…formatting CI gate Expand .editorconfig with comprehensive formatting, code style, and naming rules matching the project's existing conventions. Migrate portable settings out of GraphZen.slnx.DotSettings (keeping only ReSharper-specific features like cleanup profiles, inspection excludes, and mandatory imports). Add `dotnet format --verify-no-changes` CI step and enable EnforceCodeStyleInBuild so style violations surface during both local builds and CI. Closes #51 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Let .gitattributes (text=auto) be the sole authority on line endings. Setting end_of_line=lf in .editorconfig causes dotnet format to conflict with git's CRLF checkout on Windows. This matches the pattern used by dotnet/runtime, dotnet/roslyn, and dotnet/aspnetcore. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Matches the pattern used by dotnet/runtime, dotnet/roslyn, and dotnet/sdk. diff=csharp gives better hunk headers in diffs (shows method names), and eol=lf for shell scripts prevents CRLF issues on Windows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.editorconfigfrom 4 lines to 323 lines with comprehensive formatting, code style, naming conventions, and analyzer severity rules matching existing project conventionsGraphZen.slnx.DotSettings, keeping only ReSharper-specific features (cleanup profiles, inspection excludes, mandatory imports, user dictionary)dotnet format --verify-no-changesCI gate to.github/workflows/ci.ymlEnforceCodeStyleInBuildandGenerateDocumentationFileinDirectory.Build.propsso style violations surface during local buildsdotnet format(unnecessary usings, missing braces, formatting)Closes #51
Test plan
dotnet buildsucceeds with zero errorsdotnet format --verify-no-changespasses cleanlydotnet test— all 610 tests pass (0 failures).editorconfigrules correctly🤖 Generated with Claude Code