DRAFT: Adds serial batch execution option to AsyncDataLoader#31
Open
NeedleInAJayStack wants to merge 1 commit intoGraphQLSwift:mainfrom
Open
DRAFT: Adds serial batch execution option to AsyncDataLoader#31NeedleInAJayStack wants to merge 1 commit intoGraphQLSwift:mainfrom
serial batch execution option to AsyncDataLoader#31NeedleInAJayStack wants to merge 1 commit intoGraphQLSwift:mainfrom
Conversation
NeedleInAJayStack
changed the title
serial batch execution option to AsyncDataLoaderserial batch execution option to AsyncDataLoader
Comment on lines
+180
to
+181
| case .parallel: | ||
| try await chunks.asyncForEach { slicedBatch in |
Member
Author
There was a problem hiding this comment.
asyncForEach is serial execution, not parallel (concurrentForEach is the parallel function).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing for
serialexecution allows for better control of "fan out", where single executions with many batches can avoid overloading shared resources with concurrent requests.