Add relocateText extensions - #2208
Merged
Goooler merged 1 commit intoAug 19, 2026
Merged
Conversation
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new relocateText extension(s) intended to support relocating class/package references embedded in arbitrary text (e.g., ProGuard/R8 rules), and updates the ProGuard rules transformer to use this new behavior.
Changes:
- Introduces
Relocator.relocateText(String)andIterable<Relocator>.relocateText(String)extensions. - Updates
ProGuardFilesResourceTransformerto relocate rule lines viarelocateText. - Adds unit tests covering
SimpleRelocator.relocateTextand chained relocation behavior across multiple relocators.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/RelocationContext.kt | Adds new relocateText extension APIs for single relocators and collections. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ProGuardFilesResourceTransformer.kt | Switches ProGuard/R8 rule line relocation to the new relocateText behavior. |
| src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocatorTest.kt | Adds tests for SimpleRelocator.relocateText behavior across several configurations. |
| src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/RelocatorsTest.kt | Adds tests for chained and ordered text relocation across multiple relocators. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.