Revert "Make most transformers pattern-filterable (#2028)"#2078
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the earlier change that made several built-in resource transformers pattern-filterable, removing the newly exposed PatternSet-based APIs and returning these transformers to fixed-path matching behavior.
Changes:
- Revert multiple transformers from
PatternFilterableResourceTransformerback to plainResourceTransformerwith explicitcanTransformResourcepath checks. - Remove
PatternSet-accepting constructors / overloads that were introduced for pattern filtering. - Update the unreleased changelog entry set and the generated public API surface (
api/shadow.api) to reflect the revert.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestResourceTransformer.kt | Reverts to manifest-only matching via MANIFEST_NAME and removes pattern-filterable constructor/API. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestAppenderTransformer.kt | Reverts to manifest-only matching and removes PatternSet-based filtering support. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/Log4j2PluginsCacheFileTransformer.kt | Reverts to fixed PLUGIN_CACHE_FILE path matching and drops pattern-filterable constructor. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/GroovyExtensionModuleTransformer.kt | Reverts to matching only the two Groovy extension module descriptor paths, removing pattern filtering. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ComponentsXmlResourceTransformer.kt | Reverts to fixed components.xml path matching and drops PatternSet constructor/API. |
| docs/changes/README.md | Removes the unreleased changelog bullets that referred to exposing transformer patternSets. |
| api/shadow.api | Updates the declared public API to remove PatternSet constructors and base-class inheritance from the reverted transformers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
We don't have to expose so many `PatternSet`s for these transformers for now. This reverts commit 4a7db87
Goooler
force-pushed
the
g/20260701/revert-for-patterns
branch
from
1e54567 to
c8e2c3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have to expose so many
PatternSets for these transformers for now.Reverts #2028.