Skip to content

Replace compatGradleArtifactTransform with shadowJarWithArtifactTransformOnProjectDependency in FilteringTest#1940

Closed
Copilot wants to merge 3 commits intomainfrom
copilot/add-test-case-for-compatgradleartifacttransform
Closed

Replace compatGradleArtifactTransform with shadowJarWithArtifactTransformOnProjectDependency in FilteringTest#1940
Copilot wants to merge 3 commits intomainfrom
copilot/add-test-case-for-compatgradleartifacttransform

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

The fix for artifact transform compatibility (#882) landed in #1345, which also added a test in JavaPluginsTest. This moves that test to FilteringTest with a cleaner, more idiomatic implementation.

  • Removed compatGradleArtifactTransform from JavaPluginsTest
  • Added shadowJarWithArtifactTransformOnProjectDependency in FilteringTest:
    • Uses getDefaultProjectBuildScript and standard project conventions
    • Asserts both app and transitive lib classes are present in the shadow JAR
    • Registers a no-op TransformAction on runtimeClasspath to exercise the artifact transform path

  • CHANGELOG's "Unreleased" section has been updated, if applicable.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
  • scans-in.gradle.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…formOnProjectDependency in FilteringTest

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Copilot AI changed the title [WIP] Add test case to replace compatGradleArtifactTransform Replace compatGradleArtifactTransform with shadowJarWithArtifactTransformOnProjectDependency in FilteringTest Mar 1, 2026
@Goooler Goooler closed this Mar 1, 2026
@Goooler Goooler deleted the copilot/add-test-case-for-compatgradleartifacttransform branch March 1, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants