Fix filesystem error on long HTTP filenames by sanitizing and truncating to 100 bytes

[Copilot]

HTTP downloads fail with "filename too long" error when the resolved filename exceeds filesystem limits (typically 255 bytes, but varies by OS). Additionally, filenames with invalid characters can cause file creation errors.

Changes

• Added replaceInvalidFilenameChars() in internal/protocol/http/helper.go

  • Replaces invalid filesystem characters (\ / : * ? " < > |) with underscores
  • Ensures cross-platform compatibility (Windows and Unix-like systems)
  • Uses package-level variable for efficiency

• Added truncateFilename() in internal/protocol/http/helper.go

  • Truncates to 100 bytes while preserving file extension
  • Handles UTF-8 multi-byte characters by truncating at valid boundaries
  • Uses maxExtensionLength constant (20 bytes) to identify reasonable extensions

• Applied sanitization in Resolve() in internal/protocol/http/fetcher.go

  • First replaces invalid characters, then truncates if needed
  • Called after parsing filename from Content-Disposition header or URL path
  • Ensures all filenames are filesystem-safe before file creation
  • Consolidates all HTTP filename handling in the protocol layer

• Added 25 test cases in internal/protocol/http/filename_parse_test.go

  • 12 tests for invalid character replacement
  • 13 tests for filename truncation
  • Covers extension preservation, Unicode handling, edge cases

Example

// Before: Could fail with "filename too long" or invalid characters
file.Name = "very/long:filename*that?exceeds<filesystem>limits|and_causes_errors.pdf"

// After: Sanitized and truncated safely
file.Name = replaceInvalidFilenameChars(file.Name)
file.Name = truncateFilename(file.Name, 100)
// Result: "very_long_filename_that_exceeds_filesystem_limits_and_causes_errors_when_trying_to_create_fi.pdf"

The 100-byte limit provides a safe margin across all major filesystems while keeping filenames readable. All filename handling is now consolidated in the HTTP protocol layer since only HTTP downloads have these filename issues.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Error FileName too long</issue_title>
<issue_description>I get this error "filename too long" when the name is long.</issue_description>

<agent_instructions>Fixed the case where the http creation file name was too long, truncated if it exceeded 100 characters, and wrote the corresponding unit test</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@monkeyWie What OS?

• Fixes Error FileName too long #1237

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.55%. Comparing base (c9626cb) to head (7cfb154).

Files with missing lines	Patch %	Lines
internal/protocol/http/helper.go	86.36%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   71.58%   71.55%   -0.03%     
==========================================
  Files          47       47              
  Lines        5757     5780      +23     
==========================================
+ Hits         4121     4136      +15     
- Misses       1233     1239       +6     
- Partials      403      405       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[monkeyWie]

@copilot 直接一起把 downloader.go 里面的 util.ReplaceInvalidFilename 逻辑也直接挪到http fetcher里面处理，因为只有http下载有这个文件名的问题

[Copilot]

@copilot 直接一起把 downloader.go 里面的 util.ReplaceInvalidFilename 逻辑也直接挪到http fetcher里面处理，因为只有http下载有这个文件名的问题

Done! Moved the invalid filename character replacement logic into the HTTP fetcher (commit 8099e47).

Changes:

• Added replaceInvalidFilenameChars() in internal/protocol/http/helper.go
• Applied it in the HTTP fetcher before truncation
• Added 12 test cases to cover all invalid characters

This consolidates all filename sanitization (invalid chars + length truncation) in the HTTP protocol layer only, as you suggested.