Expose mediaType on ContentDescriptorTemplate#4499
Open
Sboti03 wants to merge 2 commits intoGoogleContainerTools:masterfrom
Open
Expose mediaType on ContentDescriptorTemplate#4499Sboti03 wants to merge 2 commits intoGoogleContainerTools:masterfrom
Sboti03 wants to merge 2 commits intoGoogleContainerTools:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes an unused suppression annotation and adds a public getter for the mediaType field within the ContentDescriptorTemplate class. The reviewer recommends adding unit test assertions in V22ManifestTemplateTest and OciManifestTemplateTest to ensure the new getter correctly returns the expected data.
jib-core/src/main/java/com/google/cloud/tools/jib/image/json/BuildableManifestTemplate.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ContentDescriptorTemplatestoresmediaTypebut does not expose it,while other descriptor fields (digest, size, urls, annotations) are accessible
via public getters.
This makes it difficult to work with OCI artifacts without using reflection.
Change
Adds a public getter:
Use case
Needed to inspect layer descriptors and select artifacts based on media type,
for example Helm chart layers:
application/vnd.cncf.helm.chart.content.v1.tar+gzipNotes
Fixes #4498 🛠️