Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dataflow/custom-containers/miniconda/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ FROM ubuntu:latest
WORKDIR /pipeline

# Set the entrypoint to Apache Beam SDK worker launcher.
COPY --from=apache/beam_python3.14_sdk:2.73.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.14_sdk:2.76.0 /opt/apache/beam /opt/apache/beam

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Apache Beam SDK container version has been updated to 2.76.0, but the apache-beam version specified in requirements.txt is still 2.37.0. This version mismatch between the SDK harness and the SDK library can lead to runtime compatibility issues on Dataflow. While it is acceptable to defer related changes in other files to subsequent pull requests, the version in requirements.txt should eventually be updated to 2.76.0 to match.

References
  1. To simplify the review process, pull requests should be focused on a single change. It is acceptable to defer related changes in other files to subsequent pull requests.

ENTRYPOINT [ "/opt/apache/beam/boot" ]

# Copy the python installation from the builder stage.
Expand Down
2 changes: 1 addition & 1 deletion dataflow/custom-containers/minimal/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ FROM python:3.14-slim
WORKDIR /pipeline

# Set the entrypoint to Apache Beam SDK worker launcher.
COPY --from=apache/beam_python3.14_sdk:2.73.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.14_sdk:2.76.0 /opt/apache/beam /opt/apache/beam

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Apache Beam SDK container version has been updated to 2.76.0, but the apache-beam version specified in requirements.txt is still 2.37.0. This version mismatch between the SDK harness and the SDK library can lead to runtime compatibility issues on Dataflow. While it is acceptable to defer related changes in other files to subsequent pull requests, the version in requirements.txt should eventually be updated to 2.76.0 to match.

References
  1. To simplify the review process, pull requests should be focused on a single change. It is acceptable to defer related changes in other files to subsequent pull requests.

ENTRYPOINT [ "/opt/apache/beam/boot" ]

# Install the requirements.
Expand Down
2 changes: 1 addition & 1 deletion dataflow/custom-containers/ubuntu/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ FROM ubuntu:focal
WORKDIR /pipeline

# Set the entrypoint to Apache Beam SDK worker launcher.
COPY --from=apache/beam_python3.14_sdk:2.73.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.14_sdk:2.76.0 /opt/apache/beam /opt/apache/beam

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Apache Beam SDK container version has been updated to 2.76.0, but the apache-beam version specified in requirements.txt is still 2.40.0. This version mismatch between the SDK harness and the SDK library can lead to runtime compatibility issues on Dataflow. While it is acceptable to defer related changes in other files to subsequent pull requests, the version in requirements.txt should eventually be updated to 2.76.0 to match.

References
  1. To simplify the review process, pull requests should be focused on a single change. It is acceptable to defer related changes in other files to subsequent pull requests.

ENTRYPOINT [ "/opt/apache/beam/boot" ]

# Install Python with pip, dev tools, distutils, and a C++ compiler.
Expand Down
2 changes: 1 addition & 1 deletion dataflow/gemma-flex-template/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ RUN pip install --no-cache-dir --upgrade pip \
# Copy SDK entrypoint binary from Apache Beam image, which makes it possible to
# use the image as SDK container image.
# The Beam version should match the version specified in requirements.txt
COPY --from=apache/beam_python3.14_sdk:2.73.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.14_sdk:2.76.0 /opt/apache/beam /opt/apache/beam

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Apache Beam SDK container version has been updated to 2.76.0, but the apache-beam version specified in requirements.txt is still 2.66.0. This violates the comment on line 32 which states that the Beam version should match the version specified in requirements.txt. While it is acceptable to defer related changes in other files to subsequent pull requests, the version in requirements.txt should eventually be updated to 2.76.0 to maintain consistency and avoid runtime compatibility issues.

References
  1. To simplify the review process, pull requests should be focused on a single change. It is acceptable to defer related changes in other files to subsequent pull requests.


# Copy Flex Template launcher binary from the launcher image, which makes it
# possible to use the image as a Flex Template base image.
Expand Down
2 changes: 1 addition & 1 deletion dataflow/gpu-examples/pytorch-minimal/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ RUN pip install --no-cache-dir --upgrade pip \
&& pip check

# Set the entrypoint to Apache Beam SDK worker launcher.
COPY --from=apache/beam_python3.14_sdk:2.73.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.14_sdk:2.76.0 /opt/apache/beam /opt/apache/beam

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Apache Beam SDK container version has been updated to 2.76.0, but the apache-beam version specified in requirements.txt is still 2.48.0. This version mismatch between the SDK harness and the SDK library can lead to runtime compatibility issues on Dataflow. While it is acceptable to defer related changes in other files to subsequent pull requests, the version in requirements.txt should eventually be updated to 2.76.0 to match.

References
  1. To simplify the review process, pull requests should be focused on a single change. It is acceptable to defer related changes in other files to subsequent pull requests.

ENTRYPOINT [ "/opt/apache/beam/boot" ]
2 changes: 1 addition & 1 deletion dataflow/snippets/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RUN update-alternatives --install /usr/bin/java java /usr/local/openjdk-8/bin/ja
WORKDIR /pipeline

# Copy files from official SDK image.
COPY --from=apache/beam_python3.14_sdk:2.73.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.14_sdk:2.76.0 /opt/apache/beam /opt/apache/beam

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Apache Beam SDK container version has been updated to 2.76.0, but the apache-beam pip package installed on line 40 is still pinned to 2.73.0. This version mismatch between the SDK harness and the SDK library can lead to runtime compatibility issues on Dataflow. The pip package version should be updated to 2.76.0 to match.

# Set the entrypoint to Apache Beam SDK launcher.
ENTRYPOINT [ "/opt/apache/beam/boot" ]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ RUN pip install --no-cache-dir --upgrade pip \

# Set the entrypoint to Apache Beam SDK worker launcher.
# Check this matches the apache-beam version in the requirements.txt
COPY --from=apache/beam_python3.14_sdk:2.73.0 /opt/apache/beam /opt/apache/beam
COPY --from=apache/beam_python3.14_sdk:2.76.0 /opt/apache/beam /opt/apache/beam

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Apache Beam SDK container version has been updated to 2.76.0, but the apache-beam version specified in requirements.txt is still 2.46.0. This violates the comment on line 27 which states that this should match the apache-beam version in requirements.txt. While it is acceptable to defer related changes in other files to subsequent pull requests, the version in requirements.txt should eventually be updated to 2.76.0 to maintain consistency and avoid runtime compatibility issues.

References
  1. To simplify the review process, pull requests should be focused on a single change. It is acceptable to defer related changes in other files to subsequent pull requests.

ENTRYPOINT [ "/opt/apache/beam/boot" ]