Skip to content

chore(datacatalog): remove decommissioned quickstart sample - #4498

Merged
angelcaamal merged 2 commits into
mainfrom
chore/remove-datacatalog-quickstart
Oct 2, 2026
Merged

angelcaamal merged 2 commits into
mainfrom
chore/remove-datacatalog-quickstart

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes b/568827334

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples. labels Oct 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Cloud Data Catalog quickstart sample files, including createFilesetEntry.js, deleteFilesetEntry.js, their associated system tests, and the package.json configuration. There are no review comments, and I have no feedback to provide.

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No reference of these files

@amcolin
amcolin marked this pull request as ready for review October 2, 2026 20:42
@amcolin
amcolin requested review from a team as code owners October 2, 2026 20:42
@snippet-bot

snippet-bot Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@angelcaamal
angelcaamal merged commit 59991a7 into main Oct 2, 2026
171 of 190 checks passed
@angelcaamal
angelcaamal deleted the chore/remove-datacatalog-quickstart branch October 2, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants