fix(healthcare): enforce json responseType and fix IAM payloads in FHIR samples#4307
Merged
fix(healthcare): enforce json responseType and fix IAM payloads in FHIR samples#4307
Conversation
… feat/fhir-batch-1-resources
…feat/fhir-batch-1-resources
… into feat/fhir-batch-1-resources
… feat/fhir-batch-1-resources
…/fhir-batch-1-resources
Configured fhirStore requests with responseType: 'json' for automatic parsing, resolving Node 20 ESM/Blob issues. Additionally, fixed the members array syntax in IAM policy payloads.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several FHIR-related scripts to include "responseType: 'json'" in API requests and implements robust error handling using try-catch blocks. Notably, "exportFhirResources.js" now uses a polling mechanism to check operation status instead of a fixed delay, and "setFhirStoreIamPolicy.js" was corrected to pass "members" as an array. Review feedback suggests explicitly setting the "Content-Type" header in "searchFhirResourcesPost.js" and adding a null check for the "entry" field in FHIR search results to prevent runtime errors.
Contributor
|
it's helpful if you put a replaces issue # (and a line for each one) |
iennae
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.