Skip to content

feat(firestore): migrate and refactor samples from nodejs-firestore#4255

Draft
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:feat/migrate-firestore-samples
Draft

feat(firestore): migrate and refactor samples from nodejs-firestore#4255
angelcaamal wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:feat/migrate-firestore-samples

Conversation

@angelcaamal
Copy link
Contributor

@angelcaamal angelcaamal commented Mar 12, 2026

Description

Fixes #b/489841801

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal requested review from a team as code owners March 12, 2026 01:06
@angelcaamal angelcaamal added api: firestore Issues related to the Firestore API. samples Issues that are directly related to samples. labels Mar 12, 2026
@snippet-bot
Copy link

snippet-bot bot commented Mar 12, 2026

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request consolidates and enhances the Node.js Firestore samples by moving them into a dedicated directory. It also expands the sample collection with new examples for advanced querying and data processing pipelines, alongside updated quickstart and distributed counter examples. This restructuring aims to improve organization, maintainability, and discoverability of the Firestore Node.js documentation samples.

Highlights

  • Sample Migration: Migrated existing Node.js Firestore samples into a newly created, dedicated firestore/ directory for better organization.
  • New Sample Additions: Introduced new samples demonstrating advanced Firestore features, specifically limitToLast queries and data processing pipelines.
  • Dependency Management and Documentation: Established a new package.json file for managing dependencies and a README.md for comprehensive documentation, tailored specifically for the Firestore samples.
Changelog
  • firestore/README.md
    • Added a comprehensive README file for the Firestore Node.js samples, including a table of contents, usage instructions, and testing guidelines.
  • firestore/limit-to-last-query.js
    • Added a new sample demonstrating how to use the limitToLast query feature in Firestore.
  • firestore/package.json
    • Added a new package.json file to manage dependencies and scripts specifically for the Firestore samples.
  • firestore/pipelines-quickstart.js
    • Added a new quickstart sample showcasing the use of Firestore pipelines for data querying and transformation.
  • firestore/quickstart.js
    • Added a quickstart sample demonstrating basic CRUD operations (create, read, update, delete) with Firestore documents.
  • firestore/solution-counters.js
    • Added a sample illustrating how to implement distributed counters using Firestore.
  • firestore/test/limit-to-last-query.test.js
    • Added unit tests to verify the functionality of the limitToLast query sample.
  • firestore/test/quickstart.test.js
    • Added unit tests to ensure the quickstart sample performs its operations correctly.
  • firestore/test/solution-counters.test.js
    • Added unit tests to validate the distributed counter sample's behavior.
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates several Firestore Node.js samples. The changes are generally good, and I've identified a few areas for improvement. There's an inconsistency in the new README.md regarding a sample file name, which could confuse users. I've suggested corrections for this in both the table of contents and the relevant section. Additionally, I've pointed out a confusing use of the .select() method in the solution-counters.js sample and suggested a clearer alternative.

@angelcaamal angelcaamal marked this pull request as draft March 12, 2026 01:11
@angelcaamal angelcaamal marked this pull request as ready for review March 12, 2026 01:27
@angelcaamal angelcaamal marked this pull request as draft March 12, 2026 18:24
@bhshkh bhshkh assigned danieljbruce and unassigned bhshkh Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants